Skip to content

Conversation

@amilcarlucas
Copy link

No description provided.

Copy link

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you save the executable as part of the build so windows users can download it?


steps:
- name: Checkout
uses: actions/checkout@v2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/checkout@v2
uses: actions/checkout@v4

choco install -y make gcc gcc-c++ qt5-win64-vs2017

- name: Setup CMake
uses: actions/setup-cmake@v1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/setup-cmake@v1
uses: actions/setup-cmake@v2

Comment on lines +24 to +28
mkdir build
cd build
cmake ..
cmake --build .
cmake --install .
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkdir build
cd build
cmake ..
cmake --build .
cmake --install .
cmake -B build
cmake --build build
cmake --install build

@Georacer
Copy link
Contributor

This looks good. Can you save the executable as part of the build so windows users can download it?

That's a good question. I think I've manually attached the binaries on the Releases page, so there's not an urge to do it. Our releases are very sparse right now.
But we would need a way to compile it locally on Windows, so that I can generate the binary to attach in the first place.

I'll try that when I find some time.

@Ryanf55
Copy link

Ryanf55 commented Apr 21, 2025

I tried the pro move of using Ubuntu and a cross compiler to get the executable, but found that getting a aysroot created with the QT dependencies too hard. Ill try on my work laptop later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants