Removed ResourceManager SDK dependency for Automation #7758
Conversation
…ceManager SDK to 1.9.1-preview for all modules/references.
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="2.0.0-preview" /> | ||
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.9.1-preview" /> |
There was a problem hiding this comment.
I don't think we should downgrade the package in Resources.
There was a problem hiding this comment.
The version was not upgraded in our repo; only in their branch. I aligned the version that we upgraded in our repo (from 1.9.0-preview to 1.9.1-preview). I changed this from 1.9.0-preview to 2.0.0-preview in a previous PR to fix their branch. But, now, I've gotten it to work without upgrading everyone to 2.0.0-preview.
| <PackageReference Include="Microsoft.Azure.Management.Redis" Version="4.4.1" PrivateAssets="All" /> | ||
| <PackageReference Include="Microsoft.Azure.Management.Relay" Version="2.0.2" PrivateAssets="All" /> | ||
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="2.0.0-preview" PrivateAssets="All" /> | ||
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.9.1-preview" PrivateAssets="All" /> |
There was a problem hiding this comment.
Should we be downgrading this version?
| <packages> | ||
| <package id="Microsoft.Azure.Management.Automation" version="3.4.0-preview" targetFramework="net452" /> | ||
| <package id="Microsoft.Azure.Management.ResourceManager" version="2.0.0-preview" targetFramework="net452" /> | ||
| <package id="Microsoft.Azure.Management.ResourceManager" version="1.9.1-preview" targetFramework="net452" /> |
There was a problem hiding this comment.
Shouldn't we just remove this altogether?
There was a problem hiding this comment.
Yes, I'm less concerned about doing that since these files (all .config files) will be removed in 2 weeks anyway. I just flat changed all Management.ResourceManager references to the same version (to be consistent).
…date various files to use .Core namespace for 'coming soon' changes.
…-powershell into AzureRM.Automation
|
@maddieclayton This should be good-to-merge once the build completes successfully. |
Description
This makes it so that Automation does not rely on the ResourceManager SDK directly. Instead, it uses our internal version of it. I've also made sure everything is using 1.9.1-preview of ResourceManager SDK (for those that do use it).
Checklist
CONTRIBUTING.mdplatyPSmodule