RFC: Add recipe for python::lief version 0.17.1 #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LIEF : Library to Instrument Executable Formats. Note that the external dependencies are not packaged separately as the LIEF cmake build system uses the zip files in the third-party directory of the release tarball (nanobind etc).
|
Wow. This is not a simply python library but a giant C++ project with a Python binding. 🤯 I think we should rather move this to the The python interface and the library should be separate multipackages I guess. Something like the following? multiPackage:
libLIEF:
multiPackage:
dev:
packageScript: cmakePackageDev
tgt:
packageScript: cmakePackageLib
python:
depends:
- name: devel::lief-libLIEF-tgt
use: []
packageScript: ???
provideDeps: [ "*-tgt" ]Regarding the embedded dependencies... It's not nice but that can be later improved if required. So let's not make this more complicated than needed. Just out of curiosity? Is this recipe intended to be used as a build helper/tool by some other recipes? Or is this cross-compiled for an embedded target? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIEF : Library to Instrument Executable Formats.
Note that the external dependencies are not packaged separately as the LIEF cmake build system uses the zip files in the third-party directory of the release tarball (nanobind etc).