Missing symfony/process dependancy

[kasparsd]

Introduced in #23.

composer-git-hooks/src/helpers.php

Line 3 in d3ba750

use Symfony\Component\Process\Process;

However, symfony/process is missing from composer.json:

composer-git-hooks/composer.json

Lines 18 to 21 in d3ba750

	"require": {
	"php": "^5.6 || >=7.0 <7.3",
	"symfony/console": "^3.2 || ^4.0"
	},

[BrainMaestro]

Yeah you're right. It wasn't picked up during development because symfony/console uses symfony/process as a dev dependency. I wonder if it's worth it to include a dependency for such a minor case. We can probably just use shell_exec

[joaorobertopb]

Hi guys!

My suggestion:

if (! function_exists('git_version')) {
    /**
     * Get latest git tag version.
     *
     * @return string
     */
    function git_version()
    {
        $gitCommand = 'git describe --tags $(git rev-list --tags --max-count=1)';
        if (class_exists('Symfony\Component\Process\Process')) {
            $process = (new Symfony\Component\Process\Process($gitCommand))->run();
            return trim($process->getOutput());
        }
        return trim(exec($gitCommand)); // Or shell_exec
    }
}

In this way we do not need to add 'symfony/process' as a dependency of the project, and we can use it without worry as long as it is a dependency of 'symfony/console'

[BrainMaestro]

That's better, but now that I think about it, I'd prefer not to use git to determine this because the version should work on computers without git installed.

[joaorobertopb]

@BrainMaestro OK no problems!

This function is not essential for the operation of the package, it can be removed if you prefer. 😄

[BrainMaestro]

It was a good idea because I always forget to update the string, but oh well. Do you want to make a PR?

[joaorobertopb]

I can send a PR at night (my time zone is UTC -3, now it's 9:20 am here).

[kasparsd]

@BrainMaestro Here is a version with symfony/process removed #26.