Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ChainSafe/js-libp2p-noise
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.0.0
Choose a base ref
...
head repository: ChainSafe/js-libp2p-noise
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.0.1
Choose a head ref
  • 12 commits
  • 33 files changed
  • 4 contributors

Commits on Dec 22, 2021

  1. Fix API docs link

    Fixes #123
    TimDaub authored Dec 22, 2021
    Configuration menu
    Copy the full SHA
    88c43d7 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. fix: remove node buffers

    Replaces node buffers with browser-friendly `Uint8Array`s.
    
    Previously we didn't want to do this because there's no equivalent
    to node's `Buffer.allocUnsafe` which doesn't set all entries of
    allocated buffers to 0.  The thing is we only actually use that in one
    place so to address this I've isolated the use of `Buffer.allocUnsafe`
    to the `alloc-unsafe.ts` file and used the `browser` field in package.json
    to override it for browser use.
    
    Running the benchmark suite in this module shows the performance
    is comparable to or even slightly better than master (I think due to not
    having to convert `Uint8Array`s to `Buffer`s any more):
    
    Before:
    
    ```console
    $ node benchmark.js
    handshake x 59.95 ops/sec ±11.20% (75 runs sampled)
    handshake x 54.68 ops/sec ±10.81% (68 runs sampled)
    handshake x 50.42 ops/sec ±11.55% (65 runs sampled)
    handshake x 53.41 ops/sec ±11.84% (68 runs sampled)
    handshake x 50.25 ops/sec ±11.80% (66 runs sampled)
    ```
    
    After:
    
    ```console
    $ node ./benchmark.js
    Initializing handshake benchmark
    Init complete, running benchmark
    handshake x 61.48 ops/sec ±11.71% (76 runs sampled)
    handshake x 59.43 ops/sec ±11.13% (73 runs sampled)
    handshake x 56.09 ops/sec ±12.02% (71 runs sampled)
    handshake x 60.05 ops/sec ±11.69% (74 runs sampled)
    handshake x 59.66 ops/sec ±10.59% (74 runs sampled)
    ```
    achingbrain committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    59b27ab View commit details
    Browse the repository at this point in the history
  2. chore: updated lockfile

    achingbrain committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    53ed91e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b397065 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ee01e42 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #124 from TimDaub/patch-1

    Fix API docs link
    mpetrunic authored Jan 3, 2022
    Configuration menu
    Copy the full SHA
    04c9009 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d7c517b View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Merge pull request #125 from achingbrain/fix/remove-node-buffers

    fix: remove node buffers
    wemeetagain authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    01c490e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc1bd68 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #118 from ChainSafe/fix/improper-nonce-handling

    fix: safely handle nonces as 64 bit uints
    wemeetagain authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    a462844 View commit details
    Browse the repository at this point in the history
  4. chore: bump version

    wemeetagain committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    df80852 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #126 from ChainSafe/chore/bump-version

    chore: bump version
    wemeetagain authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    112e247 View commit details
    Browse the repository at this point in the history
Loading