(#795) Validate organization CTID (#822)

Author: excelsior

app/models/organization.rb

@@ -16,6 +16,7 @@ class Organization < ActiveRecord::Base
 
   validates :name, presence: true
   validates :admin, presence: true
+  validate :ctid_format, if: :_ctid?
 
   normalize_attribute :name, with: :squish
 
@@ -33,8 +34,14 @@ def create_key_pair
     key_pairs.create!
   end
 
+  def ctid_format
+    return if _ctid.starts_with?('ce-') && UUID.validate(_ctid[3.._ctid.size - 1])
+
+    errors.add(:_ctid, :invalid)
+  end
+
   def ensure_ctid
-    self._ctid ||= SecureRandom.uuid
+    self._ctid ||= "ce-#{SecureRandom.uuid}"
   end
 
   def remove_deleted_envelopes

spec/api/v1/organizations_spec.rb

@@ -146,13 +146,15 @@
     # rubocop:todo RSpec/MultipleMemoizedHelpers
     context 'as admin' do # rubocop:todo RSpec/ContextWording, RSpec/MultipleMemoizedHelpers
       let(:admin) { token.admin }
+      let(:ctid) { "ce-#{SecureRandom.uuid}" }
       let(:description) { Faker::Lorem.sentence }
       let(:name) { Faker::Company.name }
       let(:token) { create(:auth_token, :admin) }
 
       before do
         post '/metadata/organizations',
              {
+               _ctid: ctid,
                name: name,
                description: description
              },
@@ -172,19 +174,48 @@
       end
       # rubocop:enable RSpec/MultipleMemoizedHelpers
 
+      context 'invalid CTID' do # rubocop:todo RSpec/ContextWording, RSpec/MultipleMemoizedHelpers, RSpec/NestedGroups
+        let(:ctid) { SecureRandom.uuid }
+
+        it 'returns 422' do
+          expect_status(:unprocessable_entity)
+          expect_json('error', 'Ctid is invalid')
+        end
+      end
+
       # rubocop:todo RSpec/MultipleMemoizedHelpers
       # rubocop:todo RSpec/NestedGroups
       context 'valid params' do # rubocop:todo RSpec/ContextWording, RSpec/MultipleMemoizedHelpers, RSpec/NestedGroups
-        # rubocop:enable RSpec/NestedGroups
-        it do
-          organization = Organization.order(:created_at).last
-          expect(organization.admin).to eq(admin)
-          expect(organization.description).to eq(description)
-          expect(organization.name).to eq(name)
-          expect_status(:created)
-          expect_json('id', organization.id)
-          expect_json('description', organization.description)
-          expect_json('name', organization.name)
+        context 'without CTID' do
+          let(:ctid) { nil }
+          # rubocop:enable RSpec/NestedGroups
+
+          it 'creates an organization with a generated CTID' do
+            organization = Organization.order(:created_at).last
+            expect(organization.admin).to eq(admin)
+            expect(organization.description).to eq(description)
+            expect(organization.name).to eq(name)
+            expect_status(:created)
+            expect_json('_ctid', organization._ctid)
+            expect_json('id', organization.id)
+            expect_json('description', organization.description)
+            expect_json('name', organization.name)
+          end
+        end
+
+        context 'with CTID' do # rubocop:todo RSpec/NestedGroups
+          it 'creates an organization' do # rubocop:todo RSpec/MultipleExpectations
+            organization = Organization.order(:created_at).last
+            expect(organization._ctid).to eq(ctid)
+            expect(organization.admin).to eq(admin)
+            expect(organization.description).to eq(description)
+            expect(organization.name).to eq(name)
+            expect_status(:created)
+            expect_json('_ctid', organization._ctid)
+            expect_json('id', organization.id)
+            expect_json('description', organization.description)
+            expect_json('name', organization.name)
+          end
         end
       end
       # rubocop:enable RSpec/MultipleMemoizedHelpers

spec/factories/organizations.rb

@@ -3,6 +3,5 @@
     admin
     description { Faker::Lorem.sentence }
     name { Faker::Company.name }
-    _ctid { SecureRandom.uuid }
   end
 end