Skip to content

Commit ba5eac5

Browse files
committed
undo jsoncpp attempt to generate *more* warnings
1 parent 8944d13 commit ba5eac5

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

CMakeLists.txt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,11 @@ macro(use_compilation_warning_as_error)
111111
if(MSVC)
112112
# Only enabled in debug because some old versions of VS STL generate
113113
# warnings when compiled in release configuration.
114-
add_compile_options($<$<CONFIG:Debug>:/WX>)
114+
#add_compile_options($<$<CONFIG:Debug>:/WX>)
115115
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
116-
add_compile_options(-Werror)
116+
#add_compile_options(-Werror)
117117
if(JSONCPP_WITH_STRICT_ISO)
118-
add_compile_options(-pedantic-errors)
118+
#add_compile_options(-pedantic-errors)
119119
endif()
120120
endif()
121121
endmacro()
@@ -134,35 +134,35 @@ endif()
134134

135135
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
136136
# using regular Clang or AppleClang
137-
add_compile_options(-Wall -Wconversion -Wshadow)
137+
#add_compile_options(-Wall -Wconversion -Wshadow)
138138

139139
if(JSONCPP_WITH_WARNING_AS_ERROR)
140-
add_compile_options(-Werror=conversion -Werror=sign-compare)
140+
#add_compile_options(-Werror=conversion -Werror=sign-compare)
141141
endif()
142142
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
143143
# using GCC
144-
add_compile_options(-Wall -Wconversion -Wshadow -Wextra)
144+
#add_compile_options(-Wall -Wconversion -Wshadow -Wextra)
145145
# not yet ready for -Wsign-conversion
146146

147147
if(JSONCPP_WITH_STRICT_ISO)
148-
add_compile_options(-Wpedantic)
148+
#add_compile_options(-Wpedantic)
149149
endif()
150150
if(JSONCPP_WITH_WARNING_AS_ERROR)
151-
add_compile_options(-Werror=conversion)
151+
#add_compile_options(-Werror=conversion)
152152
endif()
153153
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "Intel")
154154
# using Intel compiler
155-
add_compile_options(-Wall -Wconversion -Wshadow -Wextra)
155+
#add_compile_options(-Wall -Wconversion -Wshadow -Wextra)
156156

157157
if(JSONCPP_WITH_WARNING_AS_ERROR)
158-
add_compile_options(-Werror=conversion)
158+
#add_compile_options(-Werror=conversion)
159159
elseif(JSONCPP_WITH_STRICT_ISO)
160-
add_compile_options(-Wpedantic)
160+
#add_compile_options(-Wpedantic)
161161
endif()
162162
endif()
163163

164164
if(JSONCPP_WITH_WARNING_AS_ERROR)
165-
use_compilation_warning_as_error()
165+
#use_compilation_warning_as_error()
166166
endif()
167167

168168
if(JSONCPP_WITH_PKGCONFIG_SUPPORT)

0 commit comments

Comments
 (0)