Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: airbnb/javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Experience-Monks/Javascript-Code-Conventions
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 2, 2015

  1. Modified documentation section

    @mikkoh
    mikkoh committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    aa47ece View commit details
    Browse the repository at this point in the history

  2. Naming conventions. Using single letter charachters or abbreviations.… 

    … Naming booleans
    @mikkoh
    mikkoh committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    73c12d1 View commit details
    Browse the repository at this point in the history

  3. Added a note about true getters and setters via Object.defineProperty

    @mikkoh
    mikkoh committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    2e0cdba View commit details
    Browse the repository at this point in the history

  4. Implemented section for modules and jQuery

    @mikkoh
    mikkoh committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    52d8fc4 View commit details
    Browse the repository at this point in the history

  5. Changed clearhasAge to be bad

    @mikkoh
    mikkoh committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    36c6b6c View commit details
    Browse the repository at this point in the history

  6. Added a note about private methods

    @mikkoh
    mikkoh committed Mar 2, 2015
    Configuration menu
    Copy the full SHA
    0cf1531 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2015

  1. Merge pull request #1 from Jam3/dev 

    Converting AirBNB Style Guide To Jam3
    @mikkoh
    mikkoh committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    6b3ef33 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2016

  1. Added comment about lining up variables

    @njam3
    njam3 committed Feb 18, 2016
    Configuration menu
    Copy the full SHA
    2ea43bc View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2016

  1. Merge pull request #2 from Jam3/feature/variable-lineup 

    Added comment about lining up variables
    @mikkoh
    mikkoh committed Feb 19, 2016
    Configuration menu
    Copy the full SHA
    a896101 View commit details
    Browse the repository at this point in the history

  2. Update README.md 

    Fixed the word variables.

Removed translations.
    @mikkoh
    mikkoh committed Feb 19, 2016
    Configuration menu
    Copy the full SHA
    76dcc5d View commit details
    Browse the repository at this point in the history
Loading