Skip to content

[BUG]: SvgTheme does not work #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
Kirpal opened this issue Jun 20, 2024 · 0 comments · Fixed by #532
Closed
2 tasks done

[BUG]: SvgTheme does not work #531

Kirpal opened this issue Jun 20, 2024 · 0 comments · Fixed by #532
Labels
bug Something isn't working
Milestone
5.6.0

Comments

@Kirpal
Copy link
Contributor

Kirpal commented Jun 20, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Version

5.5.0+1

Command type

build_runner (Default)

What happened?

The SvgTheme no longer works when using the flutter_svg integration. The issue is that the theme should be passed to the bytesLoader when using the default SvgPicture constructor, but right now it's passed to the constructor (which is deprecated).

Relevant a pubspec.yaml.

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Kirpal Kirpal added the bug Something isn't working label Jun 20, 2024
@Kirpal Kirpal mentioned this issue Jun 20, 2024
Merged
8 tasks
@wasabeef wasabeef added this to the 5.6.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
5.6.0
Development

Successfully merging a pull request may close this issue.

fix: provide theme to SvgAssetLoader instead of SvgPicture Kirpal/flutter_gen
2 participants
@wasabeef @Kirpal