Skip to content

IAP needs some code cleanup to comply w/ Google Code Style. #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lesv opened this issue Jun 7, 2021 · 1 comment
Closed

IAP needs some code cleanup to comply w/ Google Code Style. #5386

lesv opened this issue Jun 7, 2021 · 1 comment
Assignees
@shubha-rajan
Labels
api: iap Issues related to the Identity-Aware Proxy API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@lesv
Copy link
Contributor

lesv commented Jun 7, 2021

Found in #5379

#
# iap
#

[ERROR] src/main/java/com/example/iap/BuildIapRequest.java:[18,1] (whitespace) EmptyLineSeparator: '//' should be separated from previous line.
[ERROR] src/main/java/com/example/iap/VerifyIapRequestHeader.java:[18,1] (whitespace) EmptyLineSeparator: '//' should be separated from previous line.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default-cli) on project iap-samples: You have 2 Checkstyle violations. -> [Help 1]
@lesv lesv added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. api: iap Issues related to the Identity-Aware Proxy API. samples Issues that are directly related to samples. labels Jun 7, 2021
@eaball35
Copy link
Contributor

Fixed with #5621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubha-rajan shubha-rajan

Labels
api: iap Issues related to the Identity-Aware Proxy API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lesv @shubha-rajan @eaball35