Bug: Fix the incorrect function call in http_realworld_server.py #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the file `http_realworld_server.py`, there is a reminder indicating insufficient parameters for `eval_action()`. Upon inspection, `eval_action()` is defined in `streamvln_eval.py`, which only takes one parameter, `idx`, and its code logic is only applicable to simulation. Obviously, there are six parameters here (in fact, `depth` and `camera_pose` are currently not used), so it should be calling the `step()` function from `streamvln_agent.py`, which happens to have four parameters corresponding to those in `http_realworld_server.py`. After actual testing, it is indeed calling `step()` instead of `eval_action()`. Modification plan: In the file http_realworld_server.py, replace eval_action() with step(), and comment out depth and camera_pose
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the file
http_realworld_server.py, there is a reminder indicating insufficient parameters foreval_action(). Upon inspection,eval_action()is defined instreamvln_eval.py, which only takes one parameter,idx, and its code logic is only applicable to simulation. Obviously, there are six parameters here (in fact,depthandcamera_poseare currently not used), so it should be calling thestep()function fromstreamvln_agent.py, which happens to have four parameters corresponding to those inhttp_realworld_server.py. After actual testing, it is indeed callingstep()instead ofeval_action().Modification plan: In the file http_realworld_server.py, replace eval_action() with step(), and comment out depth and camera_pose.
Just like this