Skip to content

Type stability tests #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mroavi opened this issue Apr 29, 2022 · 3 comments · Fixed by #45
Closed

Type stability tests #30

mroavi opened this issue Apr 29, 2022 · 3 comments · Fixed by #45
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mroavi
Copy link

mroavi commented Apr 29, 2022 •
edited
Loading

The promise of this package is that it is type-stable. However, there are no tests that check this. I think that this type of test is of upmost importance for this package.
@bramtayl
Copy link
Collaborator

bramtayl commented May 2, 2022 •
edited
Loading

These would be great! Want to try a PR?

@gdalle gdalle added enhancement New feature or request help wanted Extra attention is needed labels Feb 22, 2023
@gdalle
Copy link
Member

gdalle commented Feb 22, 2023

@mroavi I completely agree, do you want to try it?

@mroavi
Copy link
Author

mroavi commented Feb 22, 2023

Hey @gdalle . I'm super booked at the moment. I'll let you know once I can free up some time to contribute to this package though.

@gdalle gdalle mentioned this issue Feb 23, 2023
Merged
@gdalle gdalle closed this as completed in #45 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type-stable constructors JuliaGraphs/MetaGraphsNext.jl
3 participants
@bramtayl @mroavi @gdalle