Skip to content

ModuleFast adds trailing zeros to version numbers #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
o-l-a-v opened this issue Jan 18, 2023 · 2 comments · Fixed by #11
Closed

ModuleFast adds trailing zeros to version numbers #3

o-l-a-v opened this issue Jan 18, 2023 · 2 comments · Fixed by #11
Assignees
@JustinGrote

Comments

@o-l-a-v
Copy link

o-l-a-v commented Jan 18, 2023 •
edited
Loading

Reproduce

Install SetBIOS which in PowerShellGallery has version 1.0.

What happens

ModuleFast creates a folder 1.0.0, instead of 1.0.

This is a problem because

  • ModuleFast installs duplicate on top of what is already installed by PowerShellGet or PackageManagement.
  • Sorting on [System.Version], 1.0.0 counts as newer/higher than 1.0.

Expected behavior

ModuleFast does not modify version number from PowerShellGallery.

Screenshot

image

First folder 1.0 was installed by PackageManagement\Save-Package, 1.0.0 was installed using ModuleFast.
@JustinGrote
Copy link
Owner

@o-l-a-v sorry for the delay, I observed this too. It has to do with the very complicated logic we need to do to reconcile both the legacy .NET version syntax and the new semantic versioning syntax.

@JustinGrote JustinGrote self-assigned this Apr 20, 2023
@JustinGrote
Copy link
Owner

JustinGrote commented Dec 15, 2023 •
edited
Loading

Should be fixed by #11

@JustinGrote JustinGrote mentioned this issue Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinGrote JustinGrote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

♻️ Switch to embedded NuGetVersion from custom classes JustinGrote/ModuleFast
2 participants
@o-l-a-v @JustinGrote