Skip to content

Conversation

@chenkoucer
Copy link

@chenkoucer chenkoucer commented Nov 26, 2025

What does this PR do?

Adds support for MUSA device by implementing MUSAAccelerator in PyTorch Lightning. This enables users to train models on MUSA accelerators with the same Lightning API.

Breaking Changes

  • Support the Musa device
Before submitting
  • Was this discussed/agreed via a GitHub issue?
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing?
  • Did you update the documentation?
  • Did you write new necessary tests?
  • Did you verify tests pass locally?
  • Did you list all breaking changes?
  • Did you update the CHANGELOG?

PR review

Anyone in the community is welcome to review the PR.

Reviewer checklist
  • Is this pull request ready for review?
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory

📚 Documentation preview 📚: https://pytorch-lightning--21381.org.readthedocs.build/en/21381/

@github-actions github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Nov 26, 2025
@bhimrazy bhimrazy marked this pull request as draft November 27, 2025 06:36
@bhimrazy
Copy link
Collaborator

bhimrazy commented Nov 27, 2025

Hi @chenkoucer,
Thanks for opening this PR and taking the time to work on this!
We really appreciate the contribution.

Since this is a significant new feature that introduces a new accelerator backend, it would be helpful to first open an issue describing the motivation, expected API usage, and any relevant references. For features of this scale, maintainers typically prefer an initial design discussion over the issue to make sure the approach and long-term maintenance implications are aligned. Without that prior context, it may be difficult for the team to evaluate or move the PR forward.

Also, I noticed that the implementation relies on torch.musa. I’m not sure whether this namespace exists in upstream PyTorch—could you also provide a reference to the official documentation or library that exposes this API? That would help reviewers verify the integration and understand the expected behavior.

Thanks again!

cc: @ethanwharris @justusschock

@chenkoucer chenkoucer force-pushed the feature/support_musa_device branch from 053b990 to 4cfbf9b Compare November 28, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants