Skip to content

Commit 07c891e

Browse files
committed
Maintain consistent ordering across all charts in the report
1 parent 5ad12b3 commit 07c891e

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

report/report.html

+16-12
Original file line numberDiff line numberDiff line change
@@ -133,15 +133,6 @@ <h2>Detailed Benchmark Data</h2>
133133
.text(function(d) { return d; });
134134
}
135135

136-
function _copyAndSortResults(benchmarks) {
137-
var newBench = [];
138-
Array.prototype.push.apply(newBench, benchmarks);
139-
newBench.sort(function(e1, e2) {
140-
return d3.ascending(e1.data.rps, e2.data.rps);
141-
})
142-
return newBench
143-
}
144-
145136
function drawBars(elSelector, data, options) {'use strict';
146137
options = options || {};
147138

@@ -152,7 +143,7 @@ <h2>Detailed Benchmark Data</h2>
152143
margin = {top: 10, right: 65, bottom: 55, left: 65},
153144
width = fullWidth - margin.left - margin.right,
154145
height = fullHeight - margin.top - margin.bottom,
155-
benchmarks = _copyAndSortResults(data);
146+
benchmarks = data;
156147

157148
// data reshape
158149

@@ -285,7 +276,7 @@ <h2>Detailed Benchmark Data</h2>
285276
margin = {top: 10, right: 65, bottom: 55, left: 65},
286277
width = fullWidth - margin.left - margin.right,
287278
height = fullHeight - margin.top - margin.bottom,
288-
benchmarks = _copyAndSortResults(data);
279+
benchmarks = data;
289280

290281
// data reshape
291282

@@ -478,12 +469,21 @@ <h2>Detailed Benchmark Data</h2>
478469
}
479470

480471
var meanData = [];
472+
var order = {};
481473
for (var i = 0; i < data.benchmarks.length; i += 1) {
482474
var benchmark = data.benchmarks[i];
483475
meanData.push({
484476
'name': benchmark['name'],
485477
'data': benchmark['mean']
486-
})
478+
});
479+
}
480+
481+
meanData.sort(function(e1, e2) {
482+
return d3.ascending(e1.data.rps, e2.data.rps);
483+
})
484+
485+
for (var i = 0; i < meanData.length; i += 1) {
486+
order[meanData[i].name] = i;
487487
}
488488

489489
drawBars('#mean-bars', meanData, options);
@@ -504,6 +504,10 @@ <h2>Detailed Benchmark Data</h2>
504504
});
505505
}
506506

507+
queryData.sort(function(e1, e2) {
508+
return d3.ascending(order[e1.name], order[e2.name]);
509+
});
510+
507511
drawBars('#query-bars-' + offset, queryData, options);
508512
drawLats('#query-lats-' + offset, queryData, options);
509513
}

0 commit comments

Comments
 (0)