Skip to content

Commit a53f0cb

Browse files
committed
Apply shared checkstyles to all samples.
We use git submodules, so to check out all the code for `java-docs-samples`, we need to clone with the `--recursive` flag. ``` git clone --recursive [email protected]:GoogleCloudPlatform/java-docs-samples.git ``` To check out the directory in an already-cloned repo, run: ``` git submodule update --init --recursive ```
1 parent 8620489 commit a53f0cb

File tree

4 files changed

+12
-248
lines changed

4 files changed

+12
-248
lines changed

.gitmodules

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[submodule "java-repo-tools"]
2+
path = java-repo-tools
3+
url = https://github.com/GoogleCloudPlatform/java-repo-tools.git

google-checks.xml

-201
This file was deleted.

java-repo-tools

Submodule java-repo-tools added at 5c9a316

pom.xml

+8-47
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,17 @@
88
<artifactId>doc-samples</artifactId>
99
<packaging>pom</packaging>
1010

11+
<!-- Parent POM defines common plugins and properties. -->
12+
<parent>
13+
<groupId>com.google.cloud</groupId>
14+
<artifactId>shared-configuration</artifactId>
15+
<version>1.0.0</version>
16+
<relativePath>java-repo-tools</relativePath>
17+
</parent>
18+
1119
<properties>
1220
<appengine.sdk.version>1.9.32</appengine.sdk.version>
1321
<appengine.app.version>1</appengine.app.version>
14-
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1522
<project.http.version>1.19.0</project.http.version>
1623
<project.oauth.version>1.19.0</project.oauth.version>
1724
<maven.compiler.target>1.7</maven.compiler.target>
@@ -51,52 +58,6 @@
5158
<module>unittests</module>
5259
</modules>
5360

54-
<build>
55-
<plugins>
56-
<plugin>
57-
<groupId>org.apache.maven.plugins</groupId>
58-
<artifactId>maven-checkstyle-plugin</artifactId>
59-
<version>2.17</version>
60-
<configuration>
61-
<configLocation>google-checks.xml</configLocation>
62-
<consoleOutput>true</consoleOutput>
63-
<failOnViolation>true</failOnViolation>
64-
<failsOnError>true</failsOnError>
65-
</configuration>
66-
<executions>
67-
<execution><goals><goal>check</goal></goals></execution>
68-
</executions>
69-
</plugin>
70-
<plugin>
71-
<groupId>org.eluder.coveralls</groupId>
72-
<artifactId>coveralls-maven-plugin</artifactId>
73-
<version>3.1.0</version>
74-
<configuration>
75-
<coberturaReports>
76-
<coberturaReport>${basedir}/target/coverage.xml</coberturaReport>
77-
</coberturaReports>
78-
</configuration>
79-
</plugin>
80-
<plugin>
81-
<groupId>org.codehaus.mojo</groupId>
82-
<artifactId>cobertura-maven-plugin</artifactId>
83-
<version>2.6</version>
84-
<configuration>
85-
<outputDirectory>${basedir}/target</outputDirectory>
86-
<formats>
87-
<format>xml</format>
88-
<format>html</format>
89-
</formats>
90-
<format>xml</format>
91-
<maxmem>256m</maxmem>
92-
<!-- aggregated reports for multi-module projects -->
93-
<aggregate>true</aggregate>
94-
</configuration>
95-
</plugin>
96-
</plugins>
97-
98-
</build>
99-
10061
<dependencyManagement>
10162
<dependencies>
10263
<!-- Compile/runtime dependencies -->

0 commit comments

Comments
 (0)