Skip to content

Commit ee192fd

Browse files
committed
make tests more stable: keep timeouts in sync
1 parent 4170b5f commit ee192fd

File tree

8 files changed

+13
-13
lines changed

8 files changed

+13
-13
lines changed

ecs/cluster-cost-optimized.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,7 @@ Resources:
809809
MinSize: !Ref MinSize
810810
MaxSize: !Ref MaxSize
811811
Cooldown: '600'
812-
HealthCheckGracePeriod: 300
812+
HealthCheckGracePeriod: 900 # needs to be in sync with CreationPolicy/UpdatePolicy timeout
813813
HealthCheckType: ELB
814814
TargetGroupARNs:
815815
- !Ref DefaultTargetGroup

ecs/cluster.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -855,7 +855,7 @@ Resources:
855855
MinSize: !Ref MinSize
856856
MaxSize: !Ref MaxSize
857857
Cooldown: '120'
858-
HealthCheckGracePeriod: 300
858+
HealthCheckGracePeriod: 900 # needs to be in sync with CreationPolicy/UpdatePolicy timeout
859859
HealthCheckType: ELB
860860
TargetGroupARNs:
861861
- !Ref DefaultTargetGroup

jenkins/jenkins2-ha-agents.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1329,7 +1329,7 @@ Resources:
13291329
LaunchConfigurationName: !Ref MasterLC
13301330
MinSize: '1'
13311331
MaxSize: '1'
1332-
HealthCheckGracePeriod: 900
1332+
HealthCheckGracePeriod: 1800 # needs to be in sync with CreationPolicy/UpdatePolicy timeout
13331333
HealthCheckType: ELB
13341334
NotificationConfigurations: !If
13351335
- HasAlertTopic
@@ -2038,7 +2038,7 @@ Resources:
20382038
LaunchConfigurationName: !Ref AgentLC
20392039
MinSize: !Ref AgentMinSize
20402040
MaxSize: !Ref AgentMaxSize
2041-
HealthCheckGracePeriod: 600
2041+
HealthCheckGracePeriod: 900 # needs to be in sync with CreationPolicy/UpdatePolicy timeout
20422042
HealthCheckType: ELB
20432043
TargetGroupARNs:
20442044
- !Ref AgentELBTargetGroup

jenkins/jenkins2-ha.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -979,7 +979,7 @@ Resources:
979979
LaunchConfigurationName: !Ref MasterLC
980980
MinSize: '1'
981981
MaxSize: '1'
982-
HealthCheckGracePeriod: 900
982+
HealthCheckGracePeriod: 1800 # needs to be in sync with CreationPolicy/UpdatePolicy timeout
983983
HealthCheckType: ELB
984984
NotificationConfigurations: !If
985985
- HasAlertTopic

security/auth-proxy-ha-github-orga.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -765,7 +765,7 @@ Resources:
765765
LaunchConfigurationName: !Ref LaunchConfiguration
766766
MaxSize: '1'
767767
MinSize: '1'
768-
HealthCheckGracePeriod: 300
768+
HealthCheckGracePeriod: 600 # needs to be in sync with CreationPolicy/UpdatePolicy timeout
769769
HealthCheckType: ELB
770770
Tags:
771771
- Key: Name

test/src/test/java/de/widdix/awscftemplates/ACloudFormationTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,12 @@ protected final void deleteStack(final Context context, final String stackName)
207207
System.out.println("Skip stack deletion because of stack failure in context and FAILURE_POLICY := retain");
208208
} else {
209209
this.cf.deleteStack(new DeleteStackRequest().withStackName(stackName));
210+
if (Config.has(Config.Key.BUCKET_NAME)) {
211+
final AmazonS3 s3local = AmazonS3ClientBuilder.standard().withCredentials(this.credentialsProvider).withRegion(Config.get(Config.Key.BUCKET_REGION)).build();
212+
s3local.deleteObject(Config.get(Config.Key.BUCKET_NAME), stackName);
213+
}
214+
this.waitForStack(context, stackName, FinalStatus.DELETE_COMPLETE);
210215
}
211-
if (Config.has(Config.Key.BUCKET_NAME)) {
212-
final AmazonS3 s3local = AmazonS3ClientBuilder.standard().withCredentials(this.credentialsProvider).withRegion(Config.get(Config.Key.BUCKET_REGION)).build();
213-
s3local.deleteObject(Config.get(Config.Key.BUCKET_NAME), stackName);
214-
}
215-
this.waitForStack(context, stackName, FinalStatus.DELETE_COMPLETE);
216216
}
217217
}
218218

wordpress/wordpress-ha-aurora.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -988,7 +988,7 @@ Resources:
988988
MinSize: '2'
989989
MaxSize: '4'
990990
Cooldown: '60'
991-
HealthCheckGracePeriod: 300
991+
HealthCheckGracePeriod: 600 # needs to be in sync with CreationPolicy/UpdatePolicy timeout
992992
HealthCheckType: ELB
993993
NotificationConfigurations: !If
994994
- HasAlertTopic

wordpress/wordpress-ha.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -967,7 +967,7 @@ Resources:
967967
MinSize: '2'
968968
MaxSize: '4'
969969
Cooldown: '60'
970-
HealthCheckGracePeriod: 300
970+
HealthCheckGracePeriod: 600 # needs to be in sync with CreationPolicy/UpdatePolicy timeout
971971
HealthCheckType: ELB
972972
NotificationConfigurations: !If
973973
- HasAlertTopic

0 commit comments

Comments
 (0)