Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NICKLAB/plotly.py
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: NICKLAB/plotly.py
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: test-jupyter-circleci
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 18 commits
  • 14 files changed
  • 1 contributor

Commits on Aug 18, 2016

  1. first pass js jupyter tests

    @etpinard
    etpinard committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    1cb34f3 View commit details
    Browse the repository at this point in the history

  2. un-ignore fixture ipynb files

    @etpinard
    etpinard committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    160cadb View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2016

  1. rm useless imports

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    12cf973 View commit details
    Browse the repository at this point in the history

  2. add scan-dependency step in js test-runner

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    a8b4987 View commit details
    Browse the repository at this point in the history

  3. standardize optional requirements for CircleCI 

    - add coverage to optional requirements
- pip install optional requirements and no need for
  nothing else
    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    27442ae View commit details
    Browse the repository at this point in the history

  4. remove tagged version for ipython optioanl requirement 

    - ipython is now in the 5.x series
- the old ipython[all] conflicts with juoyter
    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    67d405a View commit details
    Browse the repository at this point in the history

  5. first pass jupyter js test on CI: 

    - add node.js to CI machine
- add PLOTLY_JUPYTER_TEST_DIR env variable
- make sure to `npm i` there
- add jupyter and ipykernel to optional requirements
- make sure to add kernel to jupyter list
- preprocess NB using that kernel
    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    61f75d8 View commit details
    Browse the repository at this point in the history

  6. fixup (pyenv environ var)

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    3239fcb View commit details
    Browse the repository at this point in the history

  7. fixup (export PYENV_VERSION before 2.7 tests)

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    3a588c1 View commit details
    Browse the repository at this point in the history

  8. remove 1.3.3 tag for nose optional requirement

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    2f4945e View commit details
    Browse the repository at this point in the history

  9. fixup (scan input in test runner)

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    4645cc1 View commit details
    Browse the repository at this point in the history

  10. generalize jupyter js tests design: 

    - init js_tests/ directory
- mv test.js -> js_tests/connected_false.js
- rename fixture ipynb accordingly
- make test runner take two args (1 for html page, 1 for js test file)
- add base test case in test_jupyter.py
    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    50fbceb View commit details
    Browse the repository at this point in the history

  11. add connected true fixture and js tests

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    dd4c7f6 View commit details
    Browse the repository at this point in the history

  12. rm 2.7.8 version

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    2579045 View commit details
    Browse the repository at this point in the history

  13. try a bunch of things

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    7e291a5 View commit details
    Browse the repository at this point in the history

  14. try

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    df18c5d View commit details
    Browse the repository at this point in the history

  15. try catch for widgets imports

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    de131c8 View commit details
    Browse the repository at this point in the history

  16. keep on trying

    @etpinard
    etpinard committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    e058894 View commit details
    Browse the repository at this point in the history
Loading