Skip to content

Conversation

@LiYuRio
Copy link
Contributor

@LiYuRio LiYuRio commented Oct 12, 2024

PR types

Others

PR changes

Others

Description

Cherry pick some pr
#9153
#9235
#9189

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2024

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 52.90%. Comparing base (80916db) to head (226fdad).
Report is 269 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/reshard/pp_reshard.py 26.31% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9253      +/-   ##
===========================================
- Coverage    53.01%   52.90%   -0.12%     
===========================================
  Files          657      657              
  Lines       106349   107009     +660     
===========================================
+ Hits         56382    56612     +230     
- Misses       49967    50397     +430     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiYuRio LiYuRio closed this Oct 14, 2024
@LiYuRio LiYuRio reopened this Oct 14, 2024
Copy link
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 0e96b0f into PaddlePaddle:develop Oct 14, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants