Implement assigning xor (^^=) operator #23242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably need to update the |
leonerd
added
the
squash-before-merge
leonerd
removed
the
squash-before-merge
|
Thoughts from PTS is that we'd like to merge this soon, so it can be tested and included in 5.41.13 - if anyone wants to review? |
Does the fact that you refer to a development release '5.41.13' mean that we are no longer aiming to issue a production release '5.42.0' on May 20? If so, I think a revision of the release schedule should be discussed on the Perl 5 Porters list. |
mauke
requested changes
May 2, 2025
There was a problem hiding this comment.
Assignment operators are supposed to return their LHS as an lvalue:
$ ./perl -Ilib -wE 'my $x; my $y = 1; ($x ||= $y) = 42; say $x'
42
But:
$ ./perl -Ilib -wE 'my $x; my $y = 1; ($x ^^= $y) = 42; say $x'
Can't modify logical xor in list assignment at -e line 1, near "42;"
Execution of -e aborted due to compilation errors.
When I added '^^' I forgot to implement or test the assigning version of it. Also it seems `pp_xor` had the left and right arguments round the wrong way; but until the asymmetry introduced by this change nobody had noticed before. This is now fixed. Also adds `B::Deparse` support for the new assigning xor operator
|
Ahyes. Lvalue context now fixed: |
Leont
approved these changes
May 4, 2025
mauke
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added '^^' I forgot to implement or test the assigning version of it.
Also it seems
pp_xorhad the left and right arguments round the wrong way; but until the asymmetry introduced by this change nobody had noticed before. This is now fixed.(I should write the perldelta)
(fixes #23238)