PHP Preload Support #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry this is so late but thanks for this contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Allow using
Icons::setAttributes()with PHP Preloading enabled.Using a namespaced constant in a function call within a class is not fully supported by php with preloading enabled and is likely to stop working in php 8 as well. Setting the default attributes using the constant on the property in the class definition is likely to remain an option.
Reading the documentation, it also seemed like using
Icons::setAttributes()multiple times would continue to modify the property on the class, instead of re-merging with the constant.The changes here solves both of these issues.