Skip to content

detection ensemble prediction #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vankhoa21991 opened this issue Mar 2, 2023 · 3 comments
Open

detection ensemble prediction #1238

vankhoa21991 opened this issue Mar 2, 2023 · 3 comments

Comments

@vankhoa21991
Copy link

Hello, in the detection example, there is no ensembling of the predictor to make prediction. This feature is going to be added in the future?

@Can-Zhao
Copy link
Contributor

Thank you for the feedback! Would you be interested in contributing a PR for it?

@vankhoa21991
Copy link
Author

I already made some adjustment for that, using the library https://github.com/ZFTurbo/Weighted-Boxes-Fusion to ensemble box predictions from different folds. However I haven't made a PR before, if you give me instruction I can make one, thanks for your help.

@Can-Zhao
Copy link
Contributor

Can-Zhao commented Apr 4, 2023

That's awesome! The complete document of making PR is here: https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md

This is my own cheatsheet to upload PR, you would need to name a $PR_BRANCH for your PR.
$local_monai_dir is the path of your local git code of MONAI.

create branch:
(1) git checkout -b $PR_BRANCH
(2) make edits at $local_monai_dir

reformat your scripts:
(3) export PYTHONPATH=${local_monai_dir}
(4) run cmd: runtests.sh --autofix
or run isort, black, flake8 one by one
(5) mypy ${your_added_script}
make edits to pass all the tests above

(6) submit PR, run cmd:

find . | grep -E "(__pycache__|\.pyc|\.pyo$)" | xargs rm -rf
git add .
git commit -a -s -m "what changes you have made"
git push origin $PR_BRANCH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants