Skip to content

Conversation

@sglyon
Copy link
Member

@sglyon sglyon commented Oct 19, 2017

This just jits the 1-dimensional quadrature routines.

The multi-dim ones are implemented using higher order functions, so they still will not work in nopython mode.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 94.768% when pulling ad8d62f on sl/jitquad into 5ac0f83 on master.

@sglyon
Copy link
Member Author

sglyon commented Oct 20, 2017

This is now ready for review/merge



def qnwgamma(n, a=None):
def qnwgamma(n, a=1.0, b=1.0, tol=3e-14):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sglyon the function signature seems to no longer correspond to the docstring.

@mmcky
Copy link
Contributor

mmcky commented Oct 22, 2017

Nice -- thanks @sglyon.

@mmcky
Copy link
Contributor

mmcky commented Oct 22, 2017

Does this need any additional tests.
This isn't usually the case as the jit is usually tested as part of an overall function.

@mmcky
Copy link
Contributor

mmcky commented Oct 22, 2017

@sglyon do you by chance have any performance comparison. No worries if you don't but if you had a ROM then I would include that in the release notes.

@sglyon
Copy link
Member Author

sglyon commented Oct 23, 2017

I don't have performance comparisons.

I did this not because of potential performance gains from calling it, but rather so I can call these routines inside other nopython jitted functions.

Good catch regarding the docstring, I'll fix that up

@mmcky
Copy link
Contributor

mmcky commented Oct 23, 2017

Thanks @sglyon - ok cool - that's a good reason. When (!) I get performance tracking up and running then it will pick up these kind of commits anyway from the git history.

@mmcky mmcky added the in-work label Oct 23, 2017
@sglyon
Copy link
Member Author

sglyon commented Oct 24, 2017

Ok, docstrings updated!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 94.769% when pulling 58125fa on sl/jitquad into 5ac0f83 on master.

@mmcky
Copy link
Contributor

mmcky commented Oct 24, 2017

thanks @sglyon.

@mmcky mmcky merged commit ea900c4 into master Oct 24, 2017
@mmcky mmcky deleted the sl/jitquad branch October 24, 2017 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants