Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ReactTooltip/react-tooltip
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.25.1
Choose a base ref
...
head repository: ReactTooltip/react-tooltip
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.25.2
Choose a head ref
  • 12 commits
  • 4 files changed
  • 3 contributors

Commits on Dec 27, 2023

  1. Configuration menu
    Copy the full SHA
    1df6d1d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ecc3115 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    59487ac View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Configuration menu
    Copy the full SHA
    dc3e8c1 View commit details
    Browse the repository at this point in the history
  2. fix: debounce prevented tooltip from closing

    There was an issue where the tooltip would stay open after the cursor
    had already left the anchor element. The issue would arise if:
    - there are two tooltip anchors A and B (same tooltip ID)
    - mouse goes over A to show the tooltip, user waits for tooltip to show
    - mouse quickly (within 50ms) leaves A, goes over B, then leaves B.
    
    The tooltip component applies debouncing on the show and hide events in
    case e.g. an anchor is simultaneously focused and mouseovered. If the
    second leave event occurred while that debounce was still active, it was
    never processed.
    
    This commit fixes the issue by making the show and hide debounce
    functions reset each other. For example, if the hide debounce has an
    active timeout, calling the debounced show function will now reset the
    timeout of the hide debounce.
    
    This solution still leaves the hide/show debounces effective against
    double-show/double-hide.
    johannkor committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    54bc0cb View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Configuration menu
    Copy the full SHA
    235503e View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    2e59f10 View commit details
    Browse the repository at this point in the history
  2. fix: debounce prevented tooltip from closing

    There was an issue where the tooltip would stay open after the cursor
    had already left the anchor element. The issue would arise if:
    - there are two tooltip anchors A and B (same tooltip ID)
    - mouse goes over A to show the tooltip, user waits for tooltip to show
    - mouse quickly (within 50ms) leaves A, goes over B, then leaves B.
    
    The tooltip component applies debouncing on the show and hide events in
    case e.g. an anchor is simultaneously focused and mouseovered. If the
    second leave event occurred while that debounce was still active, it was
    never processed.
    
    This commit fixes the issue by making the show and hide debounce
    functions reset each other. For example, if the hide debounce has an
    active timeout, calling the debounced show function will now reset the
    timeout of the hide debounce.
    
    This solution still leaves the hide/show debounces effective against
    double-show/double-hide.
    johannkor authored and gabrieljablonski committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    4f2c48f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f86b7d7 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1147 from johannkor/fix-tooltip-staying-open

    fix: open/show debounce preventing tooltip from closing properly
    gabrieljablonski authored Jan 15, 2024
    Configuration menu
    Copy the full SHA
    adcecb1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8eff46b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0b395a4 View commit details
    Browse the repository at this point in the history
Loading