2.x: provide an explanation why certain tests are ignored (#4120)

Author: DmitriyZaitsev

src/test/java/io/reactivex/flowable/BackpressureTests.java

@@ -237,7 +237,7 @@ public Publisher<Integer> apply(Integer i) {
     }
 
     @Test
-    @Ignore // the test is non-deterministic and can't be made deterministic
+    @Ignore("The test is non-deterministic and can't be made deterministic")
     public void testFlatMapAsync() {
         int NUM = (int) (Flowable.bufferSize() * 2.1);
         AtomicInteger c = new AtomicInteger();

src/test/java/io/reactivex/flowable/CombineLatestTests.java

@@ -64,7 +64,7 @@ public void accept(ExtendedResult t1) {
         }
     };
 
-    @Ignore
+    @Ignore("No longer allowed")
     @Test
     public void testNullEmitting() throws Exception {
         // FIXME this is no longer allowed

src/test/java/io/reactivex/flowable/ObservableTests.java

@@ -270,8 +270,8 @@ public Integer apply(Integer t1, Integer t2) {
         verify(w).onNext(60);
     }
 
-    @Ignore // FIXME throwing is not allowed from the create?!
-    @Test
+    @Ignore("Throwing is not allowed from the create?!")
+    @Test // FIXME throwing is not allowed from the create?!
     public void testOnSubscribeFails() {
         Subscriber<String> observer = TestHelper.mockSubscriber();
 

src/test/java/io/reactivex/internal/operators/flowable/FlowableFlatMapTest.java

@@ -431,7 +431,7 @@ public void testFlatMapTransformsMaxConcurrentNormal() {
         verify(o, never()).onError(any(Throwable.class));
     }
 
-    @Ignore // don't care for any reordering
+    @Ignore("Don't care for any reordering")
     @Test(timeout = 10000)
     public void flatMapRangeAsyncLoop() {
         for (int i = 0; i < 2000; i++) {

src/test/java/io/reactivex/internal/operators/observable/NbpOperatorFlatMapTest.java

@@ -430,7 +430,7 @@ public void testFlatMapTransformsMaxConcurrentNormal() {
         verify(o, never()).onError(any(Throwable.class));
     }
 
-    @Ignore // don't care for any reordering
+    @Ignore("Don't care for any reordering")
     @Test(timeout = 10000)
     public void flatMapRangeAsyncLoop() {
         for (int i = 0; i < 2000; i++) {

src/test/java/io/reactivex/observable/NbpCombineLatestTests.java

@@ -63,7 +63,7 @@ public void accept(ExtendedResult t1) {
         }
     };
 
-    @Ignore
+    @Ignore("No longer allowed")
     @Test
     public void testNullEmitting() throws Exception {
         // FIXME this is no longer allowed

src/test/java/io/reactivex/observable/NbpObservableTests.java

@@ -270,8 +270,8 @@ public Integer apply(Integer t1, Integer t2) {
         verify(w).onNext(60);
     }
 
-    @Ignore // FIXME throwing is not allowed from the create?!
-    @Test
+    @Ignore("Throwing is not allowed from the create?!")
+    @Test // FIXME throwing is not allowed from the create?!
     public void testOnSubscribeFails() {
         Observer<String> observer = TestHelper.mockNbpSubscriber();
 

src/test/java/io/reactivex/subscribers/SerializedObserverTest.java

@@ -254,8 +254,7 @@ public void runConcurrencyTest() {
      * 
      * @throws InterruptedException
      */
-    @Ignore
-    // this is non-deterministic ... haven't figured out what's wrong with the test yet (benjchristensen: July 2014)
+    @Ignore("this is non-deterministic ... haven't figured out what's wrong with the test yet (benjchristensen: July 2014)")
     @Test
     public void testNotificationDelay() throws InterruptedException {
         ExecutorService tp1 = Executors.newFixedThreadPool(1);
@@ -345,7 +344,7 @@ public void onNext(String t) {
      * 
      * @throws InterruptedException
      */
-    @Ignore
+    @Ignore("Demonstrates thread starvation problem. Read JavaDoc")
     @Test
     public void testThreadStarvation() throws InterruptedException {