fix: Undisposed FileSystemWatcher in WorkspaceTracker (WorkspaceTracker_45)

[kiwina]

---

name: Bug Report
description: Undisposed FileSystemWatcher in WorkspaceTracker
labels: ["bug", "memory-leak", "guaranteed", "integrations", "auto-generated"]

Thanks for your report! Please check existing issues first:
👉 https://github.com/RooCodeInc/Roo-Code/issues

App Version

N/A (Static Analysis - Detected in WorkspaceTracker_45)

API Provider

Not Applicable / Other

Model Used

N/A (Core Extension Service - WorkspaceTracker)

🔁 Steps to Reproduce

1. Setup: Roo Code VS Code extension is active, and a workspace is open.
2. Exact actions:
   • A WorkspaceTracker instance is created (typically by ClineProvider).
   • The WorkspaceTracker constructor calls registerListeners, which creates a vscode.workspace.createFileSystemWatcher("**") and adds it to an internal disposables array.
   • The WorkspaceTracker instance is later disposed of (e.g., when its owning ClineProvider is disposed).
3. What happened after each step:
   • The WorkspaceTracker.dispose() method is called.
   • Currently, this dispose method only clears updateTimer and resetTimer. It does not iterate through the disposables array to call dispose() on the FileSystemWatcher.
   • The FileSystemWatcher remains active, listening to all file events in the workspace, even though the WorkspaceTracker is no longer in use.

💥 Outcome Summary

Expected the FileSystemWatcher created by WorkspaceTracker to be disposed of when the WorkspaceTracker instance itself is disposed. However, the dispose method is incomplete, leading to the watcher leaking and continuing to consume resources.

📄 Relevant Logs or Errors (Optional)

Summary from leak-report/guaranteed/WorkspaceTracker_45.md:

The WorkspaceTracker class initializes a vscode.workspace.createFileSystemWatcher("**") in its registerListeners method. This watcher is added to the this.disposables array. However, the dispose method of WorkspaceTracker only clears this.updateTimer and this.resetTimer. It does not iterate over this.disposables to dispose of the FileSystemWatcher.

The issue is in src/integrations/workspace/WorkspaceTracker.ts where the dispose method does not clean up all disposables.