Make uncastFields private

Author: yguedidi

src/GraphNode/GraphNode.php

@@ -199,25 +199,6 @@ public function __toString()
         return $this->asJson();
     }
 
-    /**
-     * Uncasts any auto-casted datatypes.
-     * Basically the reverse of castFields().
-     *
-     * @return array
-     */
-    public function uncastFields()
-    {
-        $fields = $this->asArray();
-
-        return array_map(function ($v) {
-            if ($v instanceof \DateTime) {
-                return $v->format(\DateTime::ISO8601);
-            }
-
-            return $v;
-        }, $fields);
-    }
-
     /**
      * Casts a date value from Graph to DateTime.
      *
@@ -289,6 +270,25 @@ private function castFields(array $data)
         return $fields;
     }
 
+    /**
+     * Uncasts any auto-casted datatypes.
+     * Basically the reverse of castFields().
+     *
+     * @return array
+     */
+    private function uncastFields()
+    {
+        $fields = $this->asArray();
+
+        return array_map(function ($v) {
+            if ($v instanceof \DateTime) {
+                return $v->format(\DateTime::ISO8601);
+            }
+
+            return $v;
+        }, $fields);
+    }
+
     /**
      * Determines if a value from Graph should be cast to DateTime.
      *

tests/GraphNode/GraphNodeTest.php

@@ -126,46 +126,28 @@ public function testAGraphDateStringCanBeConvertedToADateTimeObject()
         $this->assertEquals(1405395893, $timeStamp);
     }
 
-    public function testUncastingAGraphNodeWillUncastTheDateTimeObject()
-    {
-        $graphNodeOne = new GraphNode(['foo', 'bar']);
-        $graphNodeTwo = new GraphNode([
-            'id' => '123',
-            'date' => new \DateTime('2014-07-15T03:44:53+0000'),
-            'some_collection' => $graphNodeOne,
-        ]);
-
-        $uncastArray = $graphNodeTwo->uncastFields();
-
-        $this->assertEquals([
-            'id' => '123',
-            'date' => '2014-07-15T03:44:53+0000',
-            'some_collection' => ['foo', 'bar'],
-        ], $uncastArray);
-    }
-
     public function testGettingGraphNodeAsAnArrayWillNotUncastTheDateTimeObject()
     {
         $graphNode = new GraphNode([
             'id' => '123',
-            'date' => new \DateTime('2014-07-15T03:44:53+0000'),
+            'created_time' => '2014-07-15T03:44:53+0000',
         ]);
 
         $graphNodeAsArray = $graphNode->asArray();
 
-        $this->assertInstanceOf(\DateTime::class, $graphNodeAsArray['date']);
+        $this->assertInstanceOf(\DateTime::class, $graphNodeAsArray['created_time']);
     }
 
-    public function testReturningACollectionAsJasonWillSafelyRepresentDateTimes()
+    public function testGettingAGraphNodeAsJSONWillSafelyRepresentDateTimes()
     {
         $graphNode = new GraphNode([
             'id' => '123',
-            'date' => new \DateTime('2014-07-15T03:44:53+0000'),
+            'created_time' => '2014-07-15T03:44:53+0000',
         ]);
 
         $graphNodeAsString = $graphNode->asJson();
 
-        $this->assertEquals('{"id":"123","date":"2014-07-15T03:44:53+0000"}', $graphNodeAsString);
+        $this->assertEquals('{"id":"123","created_time":"2014-07-15T03:44:53+0000"}', $graphNodeAsString);
     }
 
     public function testAnExistingPropertyCanBeAccessed()