fix redundant appending of infrastructure roles (zalando#1192)

FxKu · web-flow · commit b379db20edc0 · 2020-11-05T12:04:51.000+01:00
diff --git a/pkg/controller/util.go b/pkg/controller/util.go
@@ -341,9 +341,7 @@ func (c *Controller) getInfrastructureRole(
 				util.Coalesce(string(secretData[infraRole.RoleKey]), infraRole.DefaultRoleValue))
 		}
 
-		if roleDescr.Valid() {
-			roles = append(roles, *roleDescr)
-		} else {
+		if !roleDescr.Valid() {
 			msg := "infrastructure role %q is not complete and ignored"
 			c.logger.Warningf(msg, roleDescr)
 

Original file line number	Diff line number	Diff line change
`@@ -341,9 +341,7 @@ func (c *Controller) getInfrastructureRole(`
`341`	`341`	`util.Coalesce(string(secretData[infraRole.RoleKey]), infraRole.DefaultRoleValue))`
`342`	`342`	`}`
`343`	`343`
`344`		`- if roleDescr.Valid() {`
`345`		`- roles = append(roles, *roleDescr)`
`346`		`- } else {`
	`344`	`+ if !roleDescr.Valid() {`
`347`	`345`	`msg := "infrastructure role %q is not complete and ignored"`
`348`	`346`	`c.logger.Warningf(msg, roleDescr)`
`349`	`347`