Skip to content

Destination folder relative to config file #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pascalduez opened this issue May 25, 2015 · 5 comments
Closed

Destination folder relative to config file #403

pascalduez opened this issue May 25, 2015 · 5 comments
Assignees
Labels

Comments

@pascalduez
Copy link
Member

sassdoc foo/
--> creates a sassdoc folder in current working dir.

sassdoc foo/ -c bar/config.json
--> creates a sassdoc folder in bar/.

@valeriangalliat is that intended somehow ? I find it a bit confusing, plus it's breaking the grunt-sassdoc tests, which makes me think it's been introduced by a recent refactor.

@KittyGiraudel
Copy link
Member

That seems confusing to me.

@valeriangalliat
Copy link
Member

Oh so this was not a bug in grunt-sassdoc tests. Nope this is not intended.

The bug was introduced with c47dea1. The idea was to make dest relative to the configuration file only when defined from the configuration file. When dest is explicitely given via CLI argument, it is effectively relative to the CWD. The problem is when using the default dest.

I'm looking how to fix this.

@valeriangalliat valeriangalliat self-assigned this May 26, 2015
valeriangalliat added a commit that referenced this issue May 26, 2015
The destination should be relative to configuration file only when set
from configuration file.

Refs: #403
valeriangalliat added a commit that referenced this issue May 26, 2015
@valeriangalliat
Copy link
Member

@pascalduez In grunt-sassdoc, if dest was supposed to be relative to CWD, why was test/docs ignored in .gitignore (instead of docs)?

@pascalduez
Copy link
Member Author

@valeriangalliat In grunt-sassdoc tests I don't use the dest option so I assumed all tests to use the CWD (root of the project). In fact, there's only one breaking, the one with a config file.

@pascalduez
Copy link
Member Author

why was test/docs ignored in .gitignore (instead of docs) ?

Well well, I don't remember, that's probably wrong ;-)

valeriangalliat added a commit that referenced this issue May 26, 2015
The destination should be relative to configuration file only when set
from configuration file.

Refs: #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants