Skip to content

Commit 517c7ee

Browse files
committed
Makefile cleanup
- Remove unused clean task + Add ci task + Add build and test tasks to .PHONY Part of #3
1 parent e4bb823 commit 517c7ee

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

Makefile

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,11 @@ NAME := selenium
22
VERSION := $(or $(VERSION),$(VERSION),'2.44.0')
33
PLATFORM := $(shell uname -s)
44

5-
ifeq ($(PLATFORM), Darwin)
6-
COPYARGS := -pR
7-
else
8-
COPYARGS := -rT
9-
endif
5+
all: hub chrome firefox
106

11-
all: hub chrome firefox test
7+
build: all
128

13-
build: all clean
9+
ci: build test
1410

1511
base:
1612
cd ./Base && docker build -t $(NAME)/base:$(VERSION) .
@@ -47,9 +43,7 @@ release: tag_latest
4743
docker push $(NAME)/node-firefox
4844
@echo "*** Don't forget to create a tag. git tag rel-$(VERSION) && git push origin rel-$(VERSION)"
4945

50-
clean:
51-
5246
test:
5347
./test.sh
5448

55-
.PHONY: all base hub nodebase chrome firefox full tag_latest release clean
49+
.PHONY: all base hub nodebase chrome firefox full tag_latest release build test

0 commit comments

Comments
 (0)