Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Shopify/maintenance_tasks
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.10.2
Choose a base ref
...
head repository: Shopify/maintenance_tasks
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.10.3
Choose a head ref
  • 4 commits
  • 6 files changed
  • 2 contributors

Commits on Jul 20, 2022

  1. Handle job still existing for a cancelled run (#672)

    If a Run is force-cancelled but the job still exists in the queue, when
    it gets worked off, it causes an exception because of the state changes
    we expect.
    
    The Run moves from cancelled to running, which causes an exception which
    is rescued and the Run is moved to errored but that causes another
    exception moving from cancelled to errored.
    
    We now consider a cancelled Run as if it is cancelling, and finish the
    job early without processing any items.
    etiennebarrie committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    8661f0b View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Merge pull request #689 from Shopify/ac-dont-rescue-callback-errors

    Don't rescue callback errors
    adrianna-chang-shopify committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    5d30155 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88fed6b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec77aee View commit details
    Browse the repository at this point in the history
Loading