Skip to content

Commit 417c4d9

Browse files
committed
allowing multiple same-flags
1 parent 76edb96 commit 417c4d9

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/Helm.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,11 @@ protected function compileFlags(array $flags): array
134134
$compiledFlags = [];
135135

136136
foreach ($flags as $name => $value) {
137+
// Allow to have multiple same-flag occurences like ['--debug' => true, ['--set', 'l1=v1'], ['--set', 'l2=v2']]
138+
if (is_int($name) && is_array($value)) {
139+
[$name, $value] = $value;
140+
}
141+
137142
// If the flag has exactly bool false, then skil the flag.
138143
// So ['--some-flag' => false] would mean --some-flag does not appear.
139144
if ($value === false) {

tests/HelmTest.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,12 @@ public function test_helm_repo_upgrade()
5757
$process = Helm::upgrade(
5858
'release-2',
5959
'bitnami/postgresql',
60-
['--install' => true, '--debug' => true]
60+
[
61+
'--install' => true,
62+
'--debug' => true,
63+
['--set', 'label1=value1'],
64+
['--set', 'label2=value2'],
65+
]
6166
);
6267

6368
$process->run();

0 commit comments

Comments
 (0)