Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TxnLab/use-wallet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.0-beta.2
Choose a base ref
...
head repository: TxnLab/use-wallet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.0.0-beta.3
Choose a head ref
  • 13 commits
  • 24 files changed
  • 3 contributors

Commits on Nov 28, 2024

  1. fix(kmd): handle empty password correctly in getPassword (#318)

    When using KMD wallet for localnet, it's common that the password is set to an empty string. In this case, the memoised logic failed to detect the existing password.
    
    To fix this:
    - the password field is initialised to null
    - the memoised logic returns the password if it is not null
    PatrickDinh authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    4c2f5a8 View commit details
    Browse the repository at this point in the history
  2. test(kmd): add tests for empty and null password handling (#319)

    Add test coverage for KmdWallet's `getPassword` method to verify:
    - Empty string passwords are properly cached and reused
    - Cancelled prompts (null) fall back to empty string
    - Password prompt is only shown once when cached
    drichar authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    55ce7ad View commit details
    Browse the repository at this point in the history
  3. chore: release v3.10.1

    drichar committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    049d831 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2024

  1. feat(*): add custom password prompt for KMD and Mnemonic (#322)

    * feat(*): support customising prompt for KMD password and Mnemonic phrase
    
    There are scenarios where customsing window.prompt are needed:
    - window.prompt isn't supported, for example, on macOS WebKit
    - a better UI to display the message
    To implement this change, I have:
    - add options to customise the prompt to KMD and Mnemonic wallets
    - when the option isn't set, fallback to the default window.prompt
    
    * prettier
    PatrickDinh authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    0cfbc6d View commit details
    Browse the repository at this point in the history
  2. chore(deps): update non-major dependencies (#309)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    33cbf59 View commit details
    Browse the repository at this point in the history
  3. chore(deps): update wallet dependencies (#310)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    8c7a19b View commit details
    Browse the repository at this point in the history
  4. chore(deps): update dependency pnpm to v9.14.4 (#312)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    2342b8c View commit details
    Browse the repository at this point in the history
  5. chore(deps): update dependency vite to v6 (#321)

    * chore(deps): update dependency vite to v6
    
    * fix(solid): configure Vite for client-side testing
    
    - Disable SSR in `vite-plugin-solid` to ensure client-side environment
    - Add development and browser conditions to resolve config for proper
    test environment
    
    ---------
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Doug Richar <[email protected]>
    renovate[bot] and drichar authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    7c460e5 View commit details
    Browse the repository at this point in the history
  6. chore(deps): lock file maintenance (#306)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    b6feb21 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'main' into v4

    drichar committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    0dace06 View commit details
    Browse the repository at this point in the history
  8. test(*): add missing networks property to MnemonicWallet and KmdWallet

    Two tests that were added upstream in PR #322 instantiate wallets without the
    `networks` property, introduced on the current `v4` branch. This change adds
    the `networks` property to `MnemonicWallet` and `KmdWallet`, ensuring proper
    initialization and tests passing.
    drichar committed Dec 5, 2024
    Configuration menu
    Copy the full SHA
    d1a9696 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2024

  1. feat(pera): add auto-connect for Pera Discover browser (#323)

    * feat(pera): add auto-connect for Pera Discover browser
    
    Add automatic connection attempt when Pera wallet is initialized in the Pera
    Discover browser environment. The connection attempt is handled silently with
    appropriate logging for success and failure cases.
    
    * fix(pera): add window check to prevent SSR errors
    
    Add type check for window and navigator objects to prevent errors during
    server-side rendering. This ensures the Pera auto-connect feature only
    runs in browser environments.
    
    * refactor(pera): extract auto-connect logic into private method
    
    Extract auto-connect logic from constructor into a private async method for better
    error handling and testability. Update tests to use prototype mocking pattern
    consistent with other wallet implementations.
    
    - Move auto-connect logic into private `autoConnect` method
    - Use async/await with try/catch for better error handling
    - Update tests to mock method on prototype before wallet creation
    - Align test patterns with other wallet implementations
    
    * refactor(pera): move Pera auto-connect to resumeSession
    
    Move auto-connect logic from constructor to `resumeSession` method in Pera wallet
    implementations to fix SSR compatibility issues. Auto-connect now only triggers
    when no other wallet is active and after client-side hydration.
    
    * refactor(pera): remove unused autoConnect method
    
    Remove private `autoConnect` method from Pera wallet implementations since the
    functionality is now handled directly in resumeSession.
    drichar authored Dec 7, 2024
    Configuration menu
    Copy the full SHA
    4d04fb1 View commit details
    Browse the repository at this point in the history
  2. chore: release v4.0.0-beta.3

    drichar committed Dec 7, 2024
    Configuration menu
    Copy the full SHA
    e7eef11 View commit details
    Browse the repository at this point in the history
Loading