Skip to content

Commit 1db0cff

Browse files
Chris Elionsurfnerd
Chris Elion
authored andcommitted
Fix determinism in unit test (#2530)
* initialize random instance correctly * restore threshold (I hope)
1 parent 057add5 commit 1db0cff

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

ml-agents/mlagents/trainers/tests/test_simple_rl.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def __init__(self, use_discrete):
3838
super().__init__()
3939
self.discrete = use_discrete
4040
self._brains: Dict[str, BrainParameters] = {}
41-
self._brains[BRAIN_NAME] = BrainParameters(
41+
brain_params = BrainParameters(
4242
brain_name=BRAIN_NAME,
4343
vector_observation_space_size=OBS_SIZE,
4444
num_stacked_vector_observations=1,
@@ -47,11 +47,12 @@ def __init__(self, use_discrete):
4747
vector_action_descriptions=["moveDirection"],
4848
vector_action_space_type=0 if use_discrete else 1,
4949
)
50+
self._brains[BRAIN_NAME] = brain_params
5051

5152
# state
5253
self.position = 0.0
5354
self.step_count = 0
54-
self.random = random.Random(str(self._brains))
55+
self.random = random.Random(str(brain_params))
5556
self.goal = self.random.choice([-1, 1])
5657

5758
def step(
@@ -228,7 +229,7 @@ def _check_environment_trains(env, config):
228229
print(tc._get_measure_vals())
229230
for brain_name, mean_reward in tc._get_measure_vals().items():
230231
assert not math.isnan(mean_reward)
231-
assert mean_reward > 0.9
232+
assert mean_reward > 0.99
232233

233234

234235
@pytest.mark.parametrize("use_discrete", [True, False])

0 commit comments

Comments
 (0)