Skip to content

Commit a8262f3

Browse files
committed
tidy html, fix height at some screen sizes
1 parent b74b5be commit a8262f3

File tree

2 files changed

+12
-46
lines changed

2 files changed

+12
-46
lines changed

assets/css/year-in-review.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,12 @@ a {
5050
.YIR-container-section {
5151
max-width: var(--YIR-page-width);
5252
margin: 0 auto;
53-
height: inherit;
53+
min-height: inherit;
5454
display: flex;
5555
flex-direction: column;
5656
justify-content: center;
5757
align-items: flex-end;
58+
padding: var(--feather-grid-large) 0;
5859
}
5960

6061
p {
@@ -80,7 +81,7 @@ p {
8081
/* Sections */
8182

8283
section {
83-
height: 100vh;
84+
min-height: 100vh;
8485
}
8586

8687
section#welcome {

layouts/_default/year-in-review.html

Lines changed: 9 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -31,55 +31,20 @@
3131
<div class="YIR-container">
3232
<div class="YIR-nav-wrapper" id="YIR-navbar">
3333
<ul class="nav">
34-
<li>
35-
<a href="#welcome">
36-
<span class="YIR-nav-title">Welcome</span>
37-
</a>
38-
</li>
39-
40-
<li>
41-
<a href="#top10">
42-
<span class="YIR-nav-title">Top 10 repos</span>
43-
</a>
44-
</li>
45-
46-
<li>
47-
<a href="#locations">
48-
<span class="YIR-nav-title">Locations</span>
49-
</a>
50-
</li>
51-
52-
<li>
53-
<a href="#heat">
54-
<span class="YIR-nav-title">Heat metrics</span>
55-
</a>
56-
</li>
57-
58-
<li>
59-
<a href="#light">
60-
<span class="YIR-nav-title">Light metrics</span>
61-
</a>
62-
</li>
63-
64-
<li>
65-
<a href="#love">
66-
<span class="YIR-nav-title">Love metrics</span>
67-
</a>
68-
</li>
69-
70-
<li>
71-
<a href="#follow">
72-
<span class="YIR-nav-title">@TwitterOSS</span>
73-
</a>
74-
</li>
34+
<li><a href="#welcome"><span class="YIR-nav-title">Welcome</span></a></li>
35+
<li><a href="#top10"><span class="YIR-nav-title">Top 10 repos</span></a></li>
36+
<li><a href="#locations"><span class="YIR-nav-title">Locations</span></a></li>
37+
<li><a href="#heat"><span class="YIR-nav-title">Heat metrics</span></a></li>
38+
<li><a href="#light"><span class="YIR-nav-title">Light metrics</span></a></li>
39+
<li><a href="#love"><span class="YIR-nav-title">Love metrics</span></a></li>
40+
<li><a href="#follow"><span class="YIR-nav-title">@TwitterOSS</span></a></li>
7541
</ul>
76-
</div> <!-- End of YIR-nav-wrapper -->
77-
</div> <!-- End of YIR-container -->
42+
</div>
43+
</div>
7844

7945
<section id="welcome">
8046
<div class="YIR-container-section">
8147
<div class="YIR-header">
82-
<!-- id="type" -->
8348
<h1 class="YIR-subheading" id="date-range">{{ (now.AddDate -1 0 0).Format "Jan 2006" }} - {{ now.Format "Jan 2006" }}</h1>
8449
<h1 id="YIR-heading-text">Year in Review</h1>
8550
<h1 class="YIR-subheading" id="type">An overview of the past 12 months of activity on Twitter’s Open Source projects.</h1>

0 commit comments

Comments
 (0)