Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit 7bff6db

Browse files
[css-align] 'left' and 'right' should parse as invalid in block/cross-axis alignment
https://bugs.webkit.org/show_bug.cgi?id=181792 Reviewed by Antti Koivisto. LayoutTests/imported/w3c: Imported new Web Platform Tests for the css-align module. * resources/import-expectations.json: * web-platform-tests/css/css-align-3/content-distribution/w3c-import.log: Removed. * web-platform-tests/css/css-align-3/default-alignment/w3c-import.log: Removed. * web-platform-tests/css/css-align-3/resources/alignment-parsing-utils.js: Removed. * web-platform-tests/css/css-align-3/self-alignment/w3c-import.log: Removed. * web-platform-tests/css/css-align/content-distribution/parse-align-content-001-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-001.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-002-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-002.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-003-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-003.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-004-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-004.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-005-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-align-content-005.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-001-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-001.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-002-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-002.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-003-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-003.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-004-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-004.html: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-005-expected.txt: Added. * web-platform-tests/css/css-align/content-distribution/parse-justify-content-005.html: Added. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-001-expected.txt. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-001.html. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-002-expected.txt. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-002.html. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-003-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-003-expected.txt. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-003.html. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-004-expected.txt. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-004.html. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-005-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-005-expected.txt. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-005.html. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-006-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-006-expected.txt. * web-platform-tests/css/css-align/content-distribution/place-content-shorthand-006.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-006.html. * web-platform-tests/css/css-align/content-distribution/w3c-import.log: Added. * web-platform-tests/css/css-align/default-alignment/justify-items-legacy-001-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/justify-items-legacy-001-expected.txt. * web-platform-tests/css/css-align/default-alignment/justify-items-legacy-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/justify-items-legacy-001.html. * web-platform-tests/css/css-align/default-alignment/parse-align-items-001-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-001.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-002-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-002.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-003-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-003.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-004-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-004.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-005-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-align-items-005.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-001-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-002-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-003-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-004-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-004.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-005-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-005.html: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-006-expected.txt: Added. * web-platform-tests/css/css-align/default-alignment/parse-justify-items-006.html: Added. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-001-expected.txt. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-001.html. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-002-expected.txt. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-002.html. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-003-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-003-expected.txt. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-003.html. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-004-expected.txt. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-004.html. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-005-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-005-expected.txt. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-005.html. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-006-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-006-expected.txt. * web-platform-tests/css/css-align/default-alignment/place-items-shorthand-006.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-006.html. * web-platform-tests/css/css-align/default-alignment/w3c-import.log: Added. * web-platform-tests/css/css-align/distribution-values/space-evenly-001-expected.xht: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/distribution-values/space-evenly-001-expected.xht. * web-platform-tests/css/css-align/distribution-values/space-evenly-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/distribution-values/space-evenly-001.html. * web-platform-tests/css/css-align/distribution-values/w3c-import.log: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/distribution-values/w3c-import.log. * web-platform-tests/css/css-align/resources/alignment-parsing-utils.js: Added. (checkPlaceShorhand): (checkPlaceShorhandLonghands): (checkPlaceShorthandInvalidValues): (checkValues): (checkBadValues): (checkInitialValues): (checkInheritValues): (checkLegacyValues): (checkSupportedValues): * web-platform-tests/css/css-align/resources/w3c-import.log: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/resources/w3c-import.log. * web-platform-tests/css/css-align/self-alignment/parse-align-self-001-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-001.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-002-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-002.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-003-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-003.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-004-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-004.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-005-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-align-self-005.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-001-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-001.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-002-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-002.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-003-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-003.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-004-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-004.html: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-005-expected.txt: Added. * web-platform-tests/css/css-align/self-alignment/parse-justify-self-005.html: Added. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-001-expected.txt. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-001.html. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-002-expected.txt. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-002.html. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-003-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-003-expected.txt. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-003.html. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-004-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-004-expected.txt. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-004.html. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-005-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-005-expected.txt. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-005.html. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-006-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-006-expected.txt. * web-platform-tests/css/css-align/self-alignment/place-self-shorthand-006.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-006.html. * web-platform-tests/css/css-align/self-alignment/w3c-import.log: Added. Source/WebCore: The CSS WG resolved to remove the 'left' and 'right' values from the block/cross axis alignment properties. w3c/csswg-drafts#1403 This patch changes the CSS parsing logic of all the CSS Box Alignment properties, both block-axis (align-{self, items, content} and inline-axis (justify-{self, items, content}). Additionally, the alignment shorthands (place-{self, items, content}) have been also changed to respect the new syntax. Despite the number of layout tests changed, I don't think this change will break any content in current sites. The CSS values 'left' and 'right' were introduced by the new CSS Box Alignment spec and only implemented by the CSS Grid Layout feature, shipped last year. Additionally, the removed values have no effect on the layout result when they are applied to the block/cross-axis CSS Alignment properties. Tests: imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-align-content-001.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-align-content-002.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-align-content-003.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-align-content-004.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-align-content-005.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-justify-content-001.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-justify-content-002.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-justify-content-003.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-justify-content-004.html imported/w3c/web-platform-tests/css/css-align/content-distribution/parse-justify-content-005.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-003.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-004.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-005.html imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-006.html imported/w3c/web-platform-tests/css/css-align/default-alignment/justify-items-legacy-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-align-items-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-align-items-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-align-items-003.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-align-items-004.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-align-items-005.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-004.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-005.html imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-006.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-003.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-004.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-005.html imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-006.html imported/w3c/web-platform-tests/css/css-align/distribution-values/space-evenly-001.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-align-self-001.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-align-self-002.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-align-self-003.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-align-self-004.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-align-self-005.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-justify-self-001.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-justify-self-002.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-justify-self-003.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-justify-self-004.html imported/w3c/web-platform-tests/css/css-align/self-alignment/parse-justify-self-005.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-003.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-004.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-005.html imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-006.html * css/parser/CSSPropertyParser.cpp: (WebCore::isLeftOrRightKeyword): (WebCore::isContentPositionKeyword): (WebCore::isContentPositionOrLeftOrRightKeyword): (WebCore::consumeContentDistributionOverflowPosition): (WebCore::isSelfPositionKeyword): (WebCore::isSelfPositionOrLeftOrRightKeyword): (WebCore::consumeSelfPositionOverflowPosition): (WebCore::consumeAlignItems): (WebCore::consumeJustifyItems): (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeSimplifiedContentPosition): (WebCore::CSSPropertyParser::consumePlaceContentShorthand): (WebCore::consumeSimplifiedItemPosition): (WebCore::CSSPropertyParser::consumePlaceItemsShorthand): (WebCore::CSSPropertyParser::consumePlaceSelfShorthand): LayoutTests: Rebaseline tests because of the removal of the 'left' and right' CSS values. * css3/parse-align-content.html: * css3/parse-align-items.html: * css3/parse-align-self-expected.txt: * css3/parse-align-self.html: * css3/parse-alignment-of-root-elements-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@227432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 94b4b49 commit 7bff6db

File tree

131 files changed

+2506
-860
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

131 files changed

+2506
-860
lines changed

LayoutTests/ChangeLog

+15
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2018-01-23 Javier Fernandez <[email protected]>
2+
3+
[css-align] 'left' and 'right' should parse as invalid in block/cross-axis alignment
4+
https://bugs.webkit.org/show_bug.cgi?id=181792
5+
6+
Reviewed by Antti Koivisto.
7+
8+
Rebaseline tests because of the removal of the 'left' and right' CSS values.
9+
10+
* css3/parse-align-content.html:
11+
* css3/parse-align-items.html:
12+
* css3/parse-align-self-expected.txt:
13+
* css3/parse-align-self.html:
14+
* css3/parse-alignment-of-root-elements-expected.txt:
15+
116
2018-01-23 Simon Fraser <[email protected]>
217

318
Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.

LayoutTests/css3/parse-align-content.html

+9-39
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,6 @@
4444
align-content: center;
4545
}
4646

47-
#alignContentLeft {
48-
align-content: left;
49-
}
50-
51-
#alignContentRight {
52-
align-content: right;
53-
}
5447

5548
#alignContentFlexStart {
5649
align-content: flex-start;
@@ -68,14 +61,6 @@
6861
align-content: unsafe center ;
6962
}
7063

71-
#alignContentSafeRight {
72-
align-content: safe right;
73-
}
74-
75-
#alignContentUnsafeLeft {
76-
align-content: unsafe left;
77-
}
78-
7964
#alignContentUnsafeFlexStart {
8065
align-content: unsafe flex-start;
8166
}
@@ -141,22 +126,16 @@
141126
<div id="alignContentStart"></div>
142127
<div id="alignContentEnd"></div>
143128
<div id="alignContentCenter"></div>
144-
<div id="alignContentLeft"></div>
145-
<div id="alignContentRight"></div>
146129
<div id="alignContentFlexStart"></div>
147130
<div id="alignContentFlexEnd"></div>
148131
<div id="alignContentUnsafeEnd"></div>
149132
<div id="alignContentUnsafeCenter"></div>
150133
<div id="alignContentSafeSelfEnd"></div>
151134
<div id="alignContentSafeSelfStart"></div>
152-
<div id="alignContentSafeRight"></div>
153-
<div id="alignContentUnsafeLeft"></div>
154135
<div id="alignContentUnsafeFlexStart"></div>
155136
<div id="alignContentSafeFlexEnd"></div>
156137
<div id="alignContentEndUnsafe"></div>
157138
<div id="alignContentCenterUnsafe"></div>
158-
<div id="alignContentRightSafe"></div>
159-
<div id="alignContentLeftUnsafe"></div>
160139
<div id="alignContentFlexStartUnsafe"></div>
161140
<div id="alignContentFlexEndSafe"></div>
162141

@@ -199,10 +178,6 @@
199178
checkValues(alignContentEnd, "alignContent", "align-content", "", "end");
200179
var alignContentCenter = document.getElementById("alignContentCenter");
201180
checkValues(alignContentCenter, "alignContent", "align-content", "", "center");
202-
var alignContentLeft = document.getElementById("alignContentLeft");
203-
checkValues(alignContentLeft, "alignContent", "align-content", "", "left");
204-
var alignContentRight = document.getElementById("alignContentRight");
205-
checkValues(alignContentRight, "alignContent", "align-content", "", "right");
206181
var alignContentFlexStart = document.getElementById("alignContentFlexStart");
207182
checkValues(alignContentFlexStart, "alignContent", "align-content", "", "flex-start");
208183
var alignContentFlexEnd = document.getElementById("alignContentFlexEnd");
@@ -211,10 +186,6 @@
211186
checkValues(alignContentUnsafeEnd, "alignContent", "align-content", "", "unsafe end");
212187
var alignContentUnsafeCenter = document.getElementById("alignContentUnsafeCenter");
213188
checkValues(alignContentUnsafeCenter, "alignContent", "align-content", "", "unsafe center");
214-
var alignContentSafeRight = document.getElementById("alignContentSafeRight");
215-
checkValues(alignContentSafeRight, "alignContent", "align-content", "", "safe right");
216-
var alignContentUnsafeLeft = document.getElementById("alignContentUnsafeLeft");
217-
checkValues(alignContentUnsafeLeft, "alignContent", "align-content", "", "unsafe left");
218189
var alignContentUnsafeFlexStart = document.getElementById("alignContentUnsafeFlexStart");
219190
checkValues(alignContentUnsafeFlexStart, "alignContent", "align-content", "", "unsafe flex-start");
220191
var alignContentSafeFlexEnd = document.getElementById("alignContentSafeFlexEnd");
@@ -226,10 +197,6 @@
226197
checkValues(alignContentEndUnsafe, "alignContent", "align-content", "", "normal");
227198
var alignContentCenterUnsafe = document.getElementById("alignContentCenterUnsafe");
228199
checkValues(alignContentCenterUnsafe, "alignContent", "align-content", "", "normal");
229-
var alignContentRightSafe = document.getElementById("alignContentRightSafe");
230-
checkValues(alignContentRightSafe, "alignContent", "align-content", "", "normal");
231-
var alignContentLeftUnsafe = document.getElementById("alignContentLeftUnsafe");
232-
checkValues(alignContentLeftUnsafe, "alignContent", "align-content", "", "normal");
233200
var alignContentFlexStartUnsafe = document.getElementById("alignContentFlexStartUnsafe");
234201
checkValues(alignContentFlexStartUnsafe, "alignContent", "align-content", "", "normal");
235202
var alignContentFlexEndSafe = document.getElementById("alignContentFlexEndSafe");
@@ -276,8 +243,8 @@
276243
element.style.alignContent = "safe flex-end";
277244
checkValues(element, "alignContent", "align-content", "safe flex-end", "safe flex-end");
278245

279-
element.style.alignContent = " unsafe right";
280-
checkValues(element, "alignContent", "align-content", "unsafe right", "unsafe right");
246+
element.style.alignContent = "unsafe end";
247+
checkValues(element, "alignContent", "align-content", "unsafe end", "unsafe end");
281248

282249
element.style.justifyContent = "first baseline";
283250
checkValues(element, "justifyContent", "justify-content", "first baseline", "baseline");
@@ -304,11 +271,14 @@
304271
element = document.createElement("div");
305272
document.body.appendChild(element);
306273

307-
checkBadValues(element, "alignContent", "align-content", "");
274+
checkBadValues(element, "alignContent", "align-content", "left");
275+
checkBadValues(element, "alignContent", "align-content", "right");
308276
checkBadValues(element, "alignContent", "align-content", "auto");
309277
checkBadValues(element, "alignContent", "align-content", "unsafe auto");
310278
checkBadValues(element, "alignContent", "align-content", "auto safe");
311279
checkBadValues(element, "alignContent", "align-content", "auto left");
280+
checkBadValues(element, "alignContent", "align-content", "safe left");
281+
checkBadValues(element, "alignContent", "align-content", "unsafe right");
312282
checkBadValues(element, "alignContent", "align-content", "baseline safe");
313283
checkBadValues(element, "alignContent", "align-content", "last-baseline center");
314284
checkBadValues(element, "alignContent", "align-content", "unsafe unsafe");
@@ -342,17 +312,17 @@
342312

343313
test(function() {
344314
element.style.display = "grid";
345-
checkInitialValues(element, "alignContent", "align-content", "safe left", "normal");
315+
checkInitialValues(element, "alignContent", "align-content", "safe start", "normal");
346316
}, "Test the value 'initial' for grid containers");
347317

348318
test(function() {
349319
element.style.display = "flex";
350-
checkInitialValues(element, "alignContent", "align-content", "unsafe right", "normal");
320+
checkInitialValues(element, "alignContent", "align-content", "unsafe end", "normal");
351321
}, "Test the value 'initial' for flex containers");
352322

353323
test(function() {
354324
checkInheritValues("alignContent", "align-content", "end");
355-
checkInheritValues("alignContent", "align-content", "safe left");
325+
checkInheritValues("alignContent", "align-content", "safe start");
356326
checkInheritValues("alignContent", "align-content", "unsafe center");
357327
}, "Test the value 'inherit'");
358328
</script>

LayoutTests/css3/parse-align-items.html

+8-35
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,6 @@
4040
align-items: self-end;
4141
}
4242

43-
#alignItemsLeft {
44-
align-items: left;
45-
}
46-
47-
#alignItemsRight {
48-
align-items: right;
49-
}
50-
5143
#alignItemsFlexStart {
5244
align-items: flex-start;
5345
}
@@ -72,14 +64,6 @@
7264
align-items: safe self-start;
7365
}
7466

75-
#alignItemsSafeRight {
76-
align-items: safe right;
77-
}
78-
79-
#alignItemsUnsafeLeft {
80-
align-items: unsafe left;
81-
}
82-
8367
#alignItemsUnsafeFlexStart {
8468
align-items: unsafe flex-start;
8569
}
@@ -99,17 +83,13 @@
9983
<div id="alignItemsCenter"></div>
10084
<div id="alignItemsSelfStart"></div>
10185
<div id="alignItemsSelfEnd"></div>
102-
<div id="alignItemsLeft"></div>
103-
<div id="alignItemsRight"></div>
10486
<div id="alignItemsFlexStart"></div>
10587
<div id="alignItemsFlexEnd"></div>
10688

10789
<div id="alignItemsUnsafeEnd"></div>
10890
<div id="alignItemsUnsafeCenter"></div>
10991
<div id="alignItemsSafeSelfEnd"></div>
11092
<div id="alignItemsSafeSelfStart"></div>
111-
<div id="alignItemsSafeRight"></div>
112-
<div id="alignItemsUnsafeLeft"></div>
11393
<div id="alignItemsUnsafeFlexStart"></div>
11494
<div id="alignItemsSafeFlexEnd"></div>
11595
<script src="../resources/testharness.js"></script>
@@ -137,10 +117,6 @@
137117
checkValues(alignItemsSelfEnd, "alignItems", "align-items", "", "self-end");
138118
var alignItemsSelfStart = document.getElementById("alignItemsSelfStart");
139119
checkValues(alignItemsSelfStart, "alignItems", "align-items", "", "self-start");
140-
var alignItemsLeft = document.getElementById("alignItemsLeft");
141-
checkValues(alignItemsLeft, "alignItems", "align-items", "", "left");
142-
var alignItemsRight = document.getElementById("alignItemsRight");
143-
checkValues(alignItemsRight, "alignItems", "align-items", "", "right");
144120
var alignItemsFlexStart = document.getElementById("alignItemsFlexStart");
145121
checkValues(alignItemsFlexStart, "alignItems", "align-items", "", "flex-start");
146122
var alignItemsFlexEnd = document.getElementById("alignItemsFlexEnd");
@@ -154,10 +130,6 @@
154130
checkValues(alignItemsSafeSelfEnd, "alignItems", "align-items", "", "safe self-end");
155131
var alignItemsSafeSelfStart = document.getElementById("alignItemsSafeSelfStart");
156132
checkValues(alignItemsSafeSelfStart, "alignItems", "align-items", "", "safe self-start");
157-
var alignItemsSafeRight = document.getElementById("alignItemsSafeRight");
158-
checkValues(alignItemsSafeRight, "alignItems", "align-items", "", "safe right");
159-
var alignItemsUnsafeLeft = document.getElementById("alignItemsUnsafeLeft");
160-
checkValues(alignItemsUnsafeLeft, "alignItems", "align-items", "", "unsafe left");
161133
var alignItemsUnsafeFlexStart = document.getElementById("alignItemsUnsafeFlexStart");
162134
checkValues(alignItemsUnsafeFlexStart, "alignItems", "align-items", "", "unsafe flex-start");
163135
var alignItemsSafeFlexEnd = document.getElementById("alignItemsSafeFlexEnd");
@@ -182,9 +154,6 @@
182154
element.style.alignItems = "safe flex-end";
183155
checkValues(element, "alignItems", "align-items", "safe flex-end", "safe flex-end");
184156

185-
element.style.alignItems = "right";
186-
checkValues(element, "alignItems", "align-items", "right", "right");
187-
188157
element.style.alignItems = "center";
189158
checkValues(element, "alignItems", "align-items", "center", "center");
190159

@@ -216,10 +185,14 @@
216185
document.body.appendChild(element);
217186

218187
checkBadValues(element, "alignItems", "align-items", "auto");
188+
checkBadValues(element, "alignItems", "align-items", "left");
189+
checkBadValues(element, "alignItems", "align-items", "right");
219190
checkBadValues(element, "alignItems", "align-items", "unsafe auto");
220191
checkBadValues(element, "alignItems", "align-items", "auto safe");
221192
checkBadValues(element, "alignItems", "align-items", "auto left");
222-
checkBadValues(element, "alignItems", "align-items", "normal unsafe");
193+
checkBadValues(element, "alignItems", "align-items", "safe left");
194+
checkBadValues(element, "alignItems", "align-items", "unsafe right");
195+
checkBadValues(element, "alignItems", "align-items", "unsafe normal");
223196
checkBadValues(element, "alignItems", "align-items", "normal stretch");
224197
checkBadValues(element, "alignItems", "align-items", "baseline normal");
225198
checkBadValues(element, "alignItems", "align-items", "baseline safe");
@@ -258,17 +231,17 @@
258231

259232
test(function() {
260233
element.style.display = "grid";
261-
checkInitialValues(element, "alignItems", "align-items", "safe left", "normal");
234+
checkInitialValues(element, "alignItems", "align-items", "safe start", "normal");
262235
}, "Test the value 'initial' for grid containers");
263236

264237
test(function() {
265238
element.style.display = "flex";
266-
checkInitialValues(element, "alignItems", "align-items", "unsafe right", "normal");
239+
checkInitialValues(element, "alignItems", "align-items", "unsafe end", "normal");
267240
}, "Test the value 'initial' for flex containers");
268241

269242
test(function() {
270243
checkInheritValues("alignItems", "align-items", "end");
271-
checkInheritValues("alignItems", "align-items", "safe left");
244+
checkInheritValues("alignItems", "align-items", "safe start");
272245
checkInheritValues("alignItems", "align-items", "unsafe center");
273246
}, "Test the value 'inherit'");
274247
</script>

LayoutTests/css3/parse-align-self-expected.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ PASS Test the value 'initial' for grid containers
1111
PASS Test the value 'initial' for flex containers
1212
PASS Test the value 'initial' for positioned elements
1313
PASS Test the value 'initial' for positioned elements in grid containers
14-
PASS Test the value 'initial' for positioned elements in grid containers
14+
PASS Test the value 'initial' for positioned elements in flex containers
1515
PASS Test the value 'inherit'
1616

0 commit comments

Comments
 (0)