Add programmatic Setup support #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Apr 23, 2021
Member
Aaronontheweb
left a comment
Aaronontheweb
left a comment
There was a problem hiding this comment.
Overall, looks great to me but we need to clarify some things in the documentation
| clean: false # whether to fetch clean each time | ||
| submodules: recursive # set to 'true' for a single level of submodules or 'recursive' to get submodules of submodules | ||
| persistCredentials: true | ||
| - task: UseDotNet@2 |
| vmImage: 'ubuntu-16.04' | ||
| scriptFileName: ./build.sh | ||
| scriptArgs: all | ||
| - template: azure-pipeline.template.yaml |
| displayName: 'NuGet Pack' | ||
| vmImage: 'windows-2019' | ||
| scriptFileName: build.cmd | ||
| scriptArgs: CreateNuget nugetprerelease=dev |
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netcoreapp2.1</TargetFrameworks> | ||
| <TargetFrameworks>$(NetFrameworkTestVersion);$(NetTestVersion);$(NetCoreTestVersion)</TargetFrameworks> |
|
|
||
| namespace Akka.Persistence.MongoDb | ||
| { | ||
| public class MongoDbPersistenceSetup : Setup |
Member
There was a problem hiding this comment.
Need some XML-DOC magic here
| else | ||
| { | ||
| client = new MongoClient(setupOption.Value.SnapshotConnectionSettings); | ||
| snapshot = client.GetDatabase(setupOption.Value.SnapshotDatabaseName); |
| var snapshotDatabaseName = "theSnapshotDatabase" | ||
| var journalDatabaseName = "theJournalDatabase" | ||
| var setup = BootstrapSetup.Create() |
Member
There was a problem hiding this comment.
Need some more examples:
- Journal only
- Snapshot store only
- Both (which you have included here)
Also need to explain that you still need to set the mongodb plugin in akka.persistence.journal and akka.persistence.snapshot-store in HOCON even with these settings passed in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.