This repository was archived by the owner on Dec 30, 2022. It is now read-only.
fix(nuxt): only write $nuxt if it's writable #1117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some nuxt 2 cases (acda293#commitcomment-67430759) this.$nuxt is already defined by the framework, but not a setter, so we can't make it equal to the $nuxt of the component. Luckily in Nuxt 2, setting $nuxt isn't crucial, and can thus be skipped.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3613f04:
|
Haroenv
referenced
this pull request
Feb 28, 2022
* fix(nuxt3): forward $nuxt on the instance by default This is similar to how we forward $router and $store, but in this case it needs to happen before the beforeCreate of nuxt happens * conditionnel présent
Closed
Haroenv
commented
Sep 6, 2022
dhayab
reviewed
Sep 6, 2022
Co-authored-by: Dhaya <[email protected]>
dhayab
approved these changes
Sep 6, 2022
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…ch#1117) * fix(nuxt): only write $nuxt if it's writable In some nuxt 2 cases (algolia/vue-instantsearch@7833679#commitcomment-67430759) this.$nuxt is already defined by the framework, but not a setter, so we can't make it equal to the $nuxt of the component. Luckily in Nuxt 2, setting $nuxt isn't crucial, and can thus be skipped. * Update src/util/createServerRootMixin.js * Update src/util/createServerRootMixin.js Co-authored-by: Dhaya <[email protected]> Co-authored-by: Dhaya <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some nuxt 2 cases (acda293#commitcomment-67430759) this.$nuxt is already defined by the framework, but not a setter, so we can't make it equal to the $nuxt of the component.
Luckily in Nuxt 2, setting $nuxt isn't crucial, and can thus be skipped.