You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+8-8
Original file line number
Diff line number
Diff line change
@@ -51,7 +51,7 @@ and help you to craft the change so that it is successfully accepted into the pr
51
51
52
52
Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.
53
53
54
-
We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs we will systematically ask you to provide a minimal reproduction scenario using http://plnkr.co. Having a live, reproducible scenario gives us wealth of important information without going back & forth to you with additional questions like:
54
+
We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. In order to reproduce bugs, we will systematically ask you to provide a minimal reproduction scenario using http://plnkr.co. Having a live, reproducible scenario gives us a wealth of important information without going back & forth to you with additional questions like:
55
55
56
56
- version of Angular used
57
57
- 3rd-party libraries and their versions
@@ -61,7 +61,7 @@ A minimal reproduce scenario using http://plnkr.co/ allows us to quickly confirm
61
61
62
62
We will be insisting on a minimal reproduce scenario in order to save maintainers time and ultimately be able to fix more bugs. Interestingly, from our experience users often find coding problems themselves while preparing a minimal plunk. We understand that sometimes it might be hard to extract essentials bits of code from a larger code-base but we really need to isolate the problem before we can fix it.
63
63
64
-
Unfortunately we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that don't have enough info to be reproduced.
64
+
Unfortunately, we are not able to investigate / fix bugs without a minimal reproduction, so if we don't hear back from you we are going to close an issue that doesn't have enough info to be reproduced.
65
65
66
66
You can file new issues by filling out our [new issue form](https://github.com/angular/angular/issues/new).
67
67
@@ -173,12 +173,12 @@ The **header** is mandatory and the **scope** of the header is optional.
173
173
Any line of the commit message cannot be longer 100 characters! This allows the message to be easier
174
174
to read on GitHub as well as in various git tools.
175
175
176
-
Footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.
176
+
The footer should contain a [closing reference to an issue](https://help.github.com/articles/closing-issues-via-commit-messages/) if any.
177
177
178
178
Samples: (even more [samples](https://github.com/angular/angular/commits/master))
179
179
180
180
```
181
-
docs(changelog): update change log to beta.5
181
+
docs(changelog): update changelog to beta.5
182
182
```
183
183
```
184
184
fix(release): need to depend on latest rxjs and zone.js
@@ -203,7 +203,7 @@ Must be one of the following:
203
203
***test**: Adding missing tests or correcting existing tests
204
204
205
205
### Scope
206
-
The scope should be the name of the npm package affected (as perceived by person reading changelog generated from commit messages.
206
+
The scope should be the name of the npm package affected (as perceived by the person reading the changelog generated from commit messages.
207
207
208
208
The following is the list of supported scopes:
209
209
@@ -232,10 +232,10 @@ There are currently a few exceptions to the "use package name" rule:
232
232
* none/empty string: useful for`style`, `test` and `refactor` changes that are done across all packages (e.g. `style: add missing semicolons`)
233
233
234
234
### Subject
235
-
The subject contains succinct description of the change:
235
+
The subject contains a succinct description of the change:
236
236
237
237
* use the imperative, present tense: "change" not "changed" nor "changes"
238
-
* don't capitalize first letter
238
+
* don't capitalize the first letter
239
239
* no dot (.) at the end
240
240
241
241
### Body
@@ -266,7 +266,7 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
Note that if you have more than one Git identity, it is important to verify that you are logged in with the same ID with which you signed the CLA, before you commit changes. If not, your PR will fail the CLA check.
0 commit comments