Pin Jasmine to 3.1 to work around Promise issues #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
added a commit
to raphinesse/cordova-cli
that referenced
this pull request
Aug 30, 2018
Staying on jasmine 3.1.x for now. See: apache/cordova-lib#639
raphinesse
added a commit
to raphinesse/cordova-cli
that referenced
this pull request
Aug 30, 2018
Staying on jasmine 3.1.x for now. See: apache/cordova-lib#639
dpogue
pushed a commit
to apache/cordova-cli
that referenced
this pull request
Aug 30, 2018
Staying on jasmine 3.1.x for now. See: apache/cordova-lib#639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in Jasmine 3.2 seems to be responsible for the recent CI failures. Pinning it to 3.1 for now.
See apache/cordova-ios#393, jasmine/jasmine#1590 and #636