Skip to content

Commit 4b7bde5

Browse files
authored
Allow a HTMLLayout title to contain characters special to HTML (#513)
* Update change report
1 parent a799c93 commit 4b7bde5

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/main/cpp/htmllayout.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ void HTMLLayout::appendHeader(LogString& output, Pool& p)
183183
output.append(LOG4CXX_STR("<head>"));
184184
output.append(LOG4CXX_EOL);
185185
output.append(LOG4CXX_STR("<title>"));
186-
output.append(m_priv->title);
186+
Transform::appendEscapingTags(output, m_priv->title);
187187
output.append(LOG4CXX_STR("</title>"));
188188
output.append(LOG4CXX_EOL);
189189
output.append(LOG4CXX_STR("<style type=\"text/css\">"));

src/site/markdown/change-report-gh.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,15 @@ Release 1.5.0 includes the following new features:
5757
\[[#488](https://github.com/apache/logging-log4cxx/pull/488)\]
5858
* TelnetAppender can now deliver messages when the socket is in a TIME_WAIT state
5959
\[[#495](https://github.com/apache/logging-log4cxx/pull/495)\]
60+
* TelnetAppender can be restricted to specific network
61+
\[[#498](https://github.com/apache/logging-log4cxx/pull/498)\]
6062

6163
The following issues have been addressed:
6264

65+
* HTML output was illformed when the title contained the special HTML characters
66+
\[[#513](https://github.com/apache/logging-log4cxx/issues/513)\]
67+
* JSON output illformed when a message contained certain control characters
68+
\[[#512](https://github.com/apache/logging-log4cxx/issues/512)\]
6369
* Undefined behaviour when reloading a configuration file after calling LogManager::shutdown
6470
\[[#504](https://github.com/apache/logging-log4cxx/issues/504)\]
6571
* Compilation error when using gcc on MacOS

0 commit comments

Comments
 (0)