Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/subversion
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: trunk
Choose a base ref
...
head repository: apache/subversion
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: patch-from-stream
Choose a head ref
  • 10 commits
  • 11 files changed
  • 1 contributor

Commits on May 16, 2025

  1. Configuration menu
    Copy the full SHA
    bb27525 View commit details
    Browse the repository at this point in the history
  2. On the patch-from-stream branch: Add branch documentation.

    * BRANCH-README: New file.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/patch-from-stream@1925597 13f79535-47bb-0310-9956-ffa450edef68
    brainy committed May 16, 2025
    Configuration menu
    Copy the full SHA
    c68b6d5 View commit details
    Browse the repository at this point in the history
  3. Convert public functions for handling patches to use streams

    instead of APR files.
    
    * subversion/include/svn_client.h: Include svn_io.h for svn_stream_t.
      (svn_client_patch_stream): Read the patch from a stream instead of a file.
    * subversion/include/svn_diff.h
      (svn_diff_patch_parser_create): Likewise, read the patch from a stream.
    
    * subversion/libsvn_client/patch.c: Do not include svn_io.h.
      (svn_client_patch): Forward to svn_client_patch_stream() and remove
       the parameter checks that are repeated there.
      (svn_client_patch_stream): Read the patch from a stream instead of a file.
    
    * subversion/libsvn_diff/parse-diff.c: Include svn_io_private.h (temporary).
      (svn_diff_patch_parser_create): Read the patch from a stream, etc.
       For now, just unwrap the underlying APR file from the stream.
      (svn_patch_file_t): Replace the apr_file member with a stream.
      (svn_diff_open_patch_file): Read the patch from a stream, yet again.
      (svn_diff_close_patch_file): Close the stream.
    
    * subversion/tests/libsvn_client/client-test.c
      (test_patch): Open a stream for svn_client_patch_stream.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/patch-from-stream@1925598 13f79535-47bb-0310-9956-ffa450edef68
    brainy committed May 16, 2025
    Configuration menu
    Copy the full SHA
    de259d0 View commit details
    Browse the repository at this point in the history
  4. Fix a docstring.

    * subversion/include/svn_client.h
      (svn_client_patch_stream): The future is now!
    
    
    git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/patch-from-stream@1925599 13f79535-47bb-0310-9956-ffa450edef68
    brainy committed May 16, 2025
    Configuration menu
    Copy the full SHA
    e4534ab View commit details
    Browse the repository at this point in the history

Commits on May 18, 2025

  1. Configuration menu
    Copy the full SHA
    1c1eb9b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    19905d2 View commit details
    Browse the repository at this point in the history
  3. On the patch-from-stream branch: Add a new stream handler function that

    calculates the distance between two stream positions.
    
    * BRANCH-README: Update contents.
    
    * subversion/include/svn_error_codes.h
      (SVN_ERR_STREAM_SPAN_NOT_SUPPORTED,
       SVN_ERR_STREAM_OFFSET_TOO_LARGE): Add two new error codes.
    * subversion/include/svn_io.h
      (svn_stream_span_fn_t,
       svn_stream_set_span,
       svn_stream_supports_span,
       svn_stream_span): New functions.
    * subversion/libsvn_subr/stream.c
      (svn_stream_t::span_fn): Add new member to the private stream type.
      (svn_stream_set_span,
       svn_stream_supports_span,
       svn_stream_span): Implement the new generic stream functions.
      (span_handler_empty, svn_stream_empty): Support span for empty streams...
      (span_handler_disown, svn_stream_disown): ...and for disowned streams...
      (span_handler_apr, make_stream_from_apr_file): ...and file streams.
      (stringbuf_stream_mark, string_stream_mark): Remove. Replace with...
      (mark_str): ... this. These were identical copy/pasted structures.
      (mark_handler_stringbuf, seek_handler_stringbuf): Use mark_str.
      (mark_handler_string, seek_handler_string): And here, too.
      (off_t_can_not_represent): New helper function for type conversions.
      (span_handler_str,
       svn_stream_from_stringbuf,
       svn_stream_from_string): Support span for string and stringbuf streams...
      (span_handler_lazyopen, svn_stream_lazyopen_create): ...and lazyopen.
    * subversion/libsvn_subr/subst.c
      (translated_stream_span, stream_translated): Support span.
    
    * subversion/libsvn_repos/config_file.c
      (span_handler_rep, representation_stream): Support span.
    
    * subversion/tests/libsvn_subr/stream-test.c
      (test_stream_seek_file,
       test_stream_seek_stringbuf,
       test_stream_seek_translated,
       test_stream_compressed_empty_file): Add tests for stream span.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/patch-from-stream@1925668 13f79535-47bb-0310-9956-ffa450edef68
    brainy committed May 18, 2025
    Configuration menu
    Copy the full SHA
    c92c888 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    547defa View commit details
    Browse the repository at this point in the history
  5. Change the order of the arguments of svn_stream_span() to be consistent

    with the other generic stream functions.
    
    * subversion/include/svn_io.h
      (svn_stream_span): Put the 'stream' argument first.
    
    * subversion/tests/libsvn_subr/stream-test.c,
      subversion/libsvn_subr/stream.c,
      subversion/libsvn_subr/subst.c: : Update implementations and usage.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/patch-from-stream@1925680 13f79535-47bb-0310-9956-ffa450edef68
    brainy committed May 18, 2025
    Configuration menu
    Copy the full SHA
    13805dd View commit details
    Browse the repository at this point in the history

Commits on May 19, 2025

  1. Don't bother putting new members at the end of a private struct.

    * subversion/libsvn_subr/stream.c
      (svn_stream_t): Put span_fn in its logical place instead of at
       the end of the struct which users of the streams API don't have
       access to anyway.
    
    
    git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/patch-from-stream@1925693 13f79535-47bb-0310-9956-ffa450edef68
    brainy committed May 19, 2025
    Configuration menu
    Copy the full SHA
    0c7b533 View commit details
    Browse the repository at this point in the history
Loading