Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/subversion
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: trunk
Choose a base ref
...
head repository: apache/subversion
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: xml-writer
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on May 18, 2025

  1. Create 'xml-writer' branch to implement an XML writer. 

    XML writer is a set of functions for creating xml tags and writing them
directly to a general svn stream without temporary buffers.

This is my old work, but it's not ready for 1.15 trunk, so I decided to
commit it to a branch instead. I'll be very happy to receive any feedback.

It's mostly made to implement xpatch feature, since it would require a lot
of xml writes, but can be also used for anything in subversion, including
cmdline with `--xml` option, and maybe even ra-serf library.

git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/xml-writer@1925685 13f79535-47bb-0310-9956-ffa450edef68
    @rinrab
    rinrab committed May 18, 2025
    Configuration menu
    Copy the full SHA
    1d1fd6c View commit details
    Browse the repository at this point in the history

  2. On the 'xml-writer' branch: Implement the xml writer api. 

    * subversion/include/svn_xml.h
  (svn_xml_writer_t,
  (svn_xml_writer_create,
   svn_xml_writer_close,
   svn_xml_writer_flush,
   svn_xml_write_open_tag,
   svn_xml_write_open_tag_v,
   svn_xml_write_open_tag_hash,
   svn_xml_write_cdata_cstring,
   svn_xml_write_cdata,
   svn_xml_write_close_tag,
   svn_xml_write_header): Declare symbols.

* subversion/libsvn_subr/xml_writer.c
  (xml_stream_write,
   xml_ensure_bytes,
   xml_write_byte,
   xml_write_bytes,
   xml_write_cstring): Implement functions for writing data to the buffer.

  (svn_xml_writer_create,
   svn_xml_writer_close,
   svn_xml_writer_flush,
   svn_xml_write_open_tag,
   svn_xml_write_open_tag_v,
   svn_xml_write_open_tag_hash,
   svn_xml_write_cdata_cstring,
   svn_xml_write_cdata,
   svn_xml_write_close_tag,
   svn_xml_write_header): Implement symbols.

* subversion/tests/libsvn_subr/xml-test.c
  (test_xml_writer,
   test_xml_writer_always_flush): New tests.
  (test_funcs): Run those tests.

Any kind of feedback will be much appreciated!!


git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/xml-writer@1925686 13f79535-47bb-0310-9956-ffa450edef68
    @rinrab
    rinrab committed May 18, 2025
    Configuration menu
    Copy the full SHA
    926a172 View commit details
    Browse the repository at this point in the history

  3. On the 'xml-writer' branch: Add BRANCH-README. 

    git-svn-id: https://svn.apache.org/repos/asf/subversion/branches/xml-writer@1925687 13f79535-47bb-0310-9956-ffa450edef68
    @rinrab
    rinrab committed May 18, 2025
    Configuration menu
    Copy the full SHA
    5da97c5 View commit details
    Browse the repository at this point in the history
Loading