Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aperezdc/vim-template
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: aperezdc/vim-template
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cleanup
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 20, 2016

  1. Update copyright header

    @aperezdc
    aperezdc committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    f20846e View commit details
    Browse the repository at this point in the history

  2. Use single quotes in places where it's clearly possible 

    Using single quotes is recommended as the contents of single-quoted strings
are never interepreted in any way, and thus guaranteed to be literals.
    @aperezdc
    aperezdc committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    9be89d8 View commit details
    Browse the repository at this point in the history

  3. Use empty() instead of comparing with the empty string 

    Using the function better conveys the intention, and it is likely to be more
efficient because less temporary string literals are used.
    @aperezdc
    aperezdc committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    830f646 View commit details
    Browse the repository at this point in the history

  4. Functions: s: instead of <SID>, add [!] and [abort] 

    See:
https://google.github.io/styleguide/vimscriptguide.xml?showone=Functions#Functions

* s: is more consistent with the rest of the source code.
* [!] allows developers to reload their functions without complaint.
* [abort] forces the function to halt when it encounters an error.
    @aperezdc
    aperezdc committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    93c48ed View commit details
    Browse the repository at this point in the history

  5. Move bulk of the plugin to an autoloaded script 

    This improves Vim loading time by making most of the code to be loaded
on-demand on the first usage of the plugin: either when a buffer for a
new file is created (via a BufNewFile autocommand), or when the :Template
or :TemplateHere commands are used -- opening existing files won't cause
the autoload script to be loaded and parsed by Vim.
    @aperezdc
    aperezdc committed Jun 20, 2016
    Configuration menu
    Copy the full SHA
    024f455 View commit details
    Browse the repository at this point in the history
Loading