Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3.10.2
Choose a base ref
...
head repository: apple/swift-crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3.11.0
Choose a head ref
  • 5 commits
  • 28 files changed
  • 2 contributors

Commits on Feb 10, 2025

  1. Add the necessary swift defines in CMake for Crypto module (#323)

    ### Checklist
    - [X] I've run tests to see all new and existing tests pass
    - [X] I've followed the code style of the rest of the project
    - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md)
    - [X] I've updated the documentation if necessary
    
    #### If you've made changes to `gyb` files
    - [X] I've run `.script/generate_boilerplate_files_with_gyb` and
    included updated generated files in a commit of this pull request
    
    ### Motivation:
    
    When building SwiftPM with CMake and the swift-crypto package there are
    errors being produced on macOS relating to missing imports provided by
    the CryptoKit package.
    
    ### Modifications:
    
    Modify the CMakeLists.txt file for the Crypto target so that the defines
    are set like they are in the Package.swift.
    
    ### Result:
    
    After the change, building SwiftPM with CMake on macOS should work.
    cmcgee1024 authored Feb 10, 2025
    Configuration menu
    Copy the full SHA
    75a3eca View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2025

  1. Fix macos build failures cmake (#324)

    Remove the extra true values for the swift defines in the CryptoExtras
    modules CMakeLists.txt file.
    
    ### Checklist
    - [X] I've run tests to see all new and existing tests pass
    - [X] I've followed the code style of the rest of the project
    - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md)
    - [X] I've updated the documentation if necessary
    
    #### If you've made changes to `gyb` files
    - [X] I've run `.script/generate_boilerplate_files_with_gyb` and
    included updated generated files in a commit of this pull request
    
    ### Motivation:
    
    The defines don't take effect with a value. Remove the value "true" from
    them.
    
    ### Modifications:
    
    Modified the CMakeLists.txt file in the CryptoExtras module.
    
    ### Result:
    
    After the change the swift defines will hopefully be defined correctly.
    cmcgee1024 authored Feb 11, 2025
    Configuration menu
    Copy the full SHA
    472de78 View commit details
    Browse the repository at this point in the history
  2. Add workaround for missing multi-threaded dll support on windows clan…

    …g/ASM (#325)
    
    When building using CMake with Windows, there is an error regarding
    missing MultithreadedDLL support. Work around this by setting the
    MSVC_RUNTIME_LIBRARY on that platform to a supported option.
    
    ### Checklist
    - [X] I've run tests to see all new and existing tests pass
    - [X] I've followed the code style of the rest of the project
    - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md)
    - [X] I've updated the documentation if necessary
    
    #### If you've made changes to `gyb` files
    - [X] I've run `.script/generate_boilerplate_files_with_gyb` and
    included updated generated files in a commit of this pull request
    
    ### Motivation:
    
    I'm trying to build swift-crypto on Windows with CMake.
    
    ### Modifications:
    
    I've modified the CMakelists.txt such that the clang can compile the
    assembly files on Windows.
    
    ### Result:
    
    Hopefully, Windows builds of swift-crypto are working.
    cmcgee1024 authored Feb 11, 2025
    Configuration menu
    Copy the full SHA
    06fc9b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2025

  1. extras: Add API for Anonymous Rate-Limited Credentials, ARC(P-384) (#328

    )
    
    ## Motivation
    
    We would like to provide support for ARCV1(P-384), as defined in [IETF
    Internet Draft: Anonymous Rate-Limited
    Credentials](https://datatracker.ietf.org/doc/draft-yun-cfrg-arc/).
    
    ## Modifications
    
    - Add internal implementation, generic over the NIST curves.
    - Add public API for ARC(P-384), under `P384._ARCV1`.
    
    ## Result
    
    New API for current draft of ARC.
    
    ## Tests
    
    - End to end tests of internal implementation and API surface.
    - Test vector tests of internal implementation and API surface, from the
    spec draft.
    simonjbeaumont authored Feb 14, 2025
    Configuration menu
    Copy the full SHA
    b81059d View commit details
    Browse the repository at this point in the history
  2. Fix CMakeLists.txt for Windows (#326)

    This change prepares swift-crypto for use on Windows with CMake and also
    the Package.swift for use in the Swift toolchain CI system.
    
    ### Checklist
    - [X] I've run tests to see all new and existing tests pass
    - [X] I've followed the code style of the rest of the project
    - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md)
    - [X] I've updated the documentation if necessary
    
    #### If you've made changes to `gyb` files
    - [X] I've run `.script/generate_boilerplate_files_with_gyb` and
    included updated generated files in a commit of this pull request
    
    ### Motivation:
    
    Upgrading swift-crypto from an older version requires that Windows works
    properly with CMake, and also SwiftPM.
    
    ### Modifications:
    
    Modify the CMakeLists.txt files and the generator script so that it
    conditionally adds assembly files for non-Windows platforms. Prepare the
    Package.swift file for use in Swift CI pipelines, by consulting an
    environment to either use the absolute URL, or a prepared version of the
    swift-asn1 dependency.
    
    ### Result:
    
    After this change it should be possible to build with the newest
    swift-crypto in the Swift CI system.
    cmcgee1024 authored Feb 14, 2025
    Configuration menu
    Copy the full SHA
    b6049c0 View commit details
    Browse the repository at this point in the history
Loading