Skip to content

ArangoDB.Builder should support specifying HostnameVerifier #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pvgoran opened this issue Apr 21, 2020 · 1 comment · Fixed by #358
Closed

ArangoDB.Builder should support specifying HostnameVerifier #341

pvgoran opened this issue Apr 21, 2020 · 1 comment · Fixed by #358
Assignees

Comments

@pvgoran
Copy link

pvgoran commented Apr 21, 2020

For now, it's possible to customize a TLS connection by specifying SSLContext. While it is already very useful, it is incomplete without the ability to specify HostnameVerifier. (Basically, I want to be able to connect to a TLS endpoint with a certificate that doesn't have to have a matching Common Name or Alternative Names.)

I propose adding the method hostnameVerifier() to ArangoDB.Builder, which would propagate a HostnameVerifier to com.arangodb.internal.http.HttpConnection, which in turn would pass it to the created SSLConnectionSocketFactory instance.

It should be quite easy to implement, I'll try to submit a PR when I have some time.

@rashtao rashtao self-assigned this Sep 3, 2020
@pvgoran
Copy link
Author

pvgoran commented Sep 3, 2020

@rashtao Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants