Skip to content

Change repo name need a new PR? #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lakshanthad opened this issue Jan 19, 2022 · 3 comments · Fixed by #926
Closed

Change repo name need a new PR? #924

lakshanthad opened this issue Jan 19, 2022 · 3 comments · Fixed by #926
Assignees
Labels
conclusion: resolved Issue was resolved topic: URL change Change library repository URL

Comments

@lakshanthad
Copy link
Contributor

lakshanthad commented Jan 19, 2022

Hello. I have already added a library to Arduino Library Manager and the library URL is available in repositories.txt. However, now I have renamed the repo. Do I need to PR again?

This is the library:
https://github.com/arduino/library-registry/blob/main/repositories.txt#L3322

Now the library URL after name change is this:
https://github.com/Seeed-Studio/Seeed_Arduino_LSM6DS3

I can only see instructions on changing URL, but it is not a complete URL change. That is because the renaming of repo can still point to the new URL from the old URL.

Help would be appreciated!

Thank you.

@per1234
Copy link
Contributor

per1234 commented Jan 19, 2022

Hi @lakshanthad.

Do I need to PR again?

It is fine to make the request via an issue. I have submitted the necessary PR on your behalf.

I can only see instructions on changing URL, but it is not a complete URL change. That is because the renaming of repo can still point to the new URL from the old URL.

Yes, GitHub will automatically redirect the old URL to the new one. However, it is safest not to rely on that redirect working forever, so it is best to update the URL.

The requested change is now in progress:

You are welcome to check the proposed change in that PR.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests and closes those issues/PRs when that is done. If you are subscribed to the PR linked above, you'll get a notification at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Jan 19, 2022
@lakshanthad
Copy link
Contributor Author

Thank you very much for the clarification. Really appreciate it!

The proposed changes look good to me.

Thanks again.

@per1234 per1234 linked a pull request Jan 19, 2022 that will close this issue
@umbynos
Copy link
Contributor

umbynos commented Jan 19, 2022

Solved in #926

@umbynos umbynos closed this as completed Jan 19, 2022
@per1234 per1234 added the conclusion: resolved Issue was resolved label Feb 3, 2022
@per1234 per1234 removed the status: pending backend Depends on backend maintenance operations label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: URL change Change library repository URL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants