Skip to content

Commit ad2bf62

Browse files
committed
Remove assertion about GCS credentials always being null when not set explicetly
After we fixed getting application credentials in a GCE environment in elastic#82974, we can actually get credentials set automatically when creating a new GCS client Fixes elastic#83131
1 parent c775642 commit ad2bf62

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

modules/repository-gcs/src/test/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageServiceTests.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
package org.elasticsearch.repositories.gcs;
1010

11-
import com.google.auth.Credentials;
1211
import com.google.cloud.http.HttpTransportOptions;
1312
import com.google.cloud.storage.Storage;
1413

@@ -35,7 +34,6 @@
3534

3635
public class GoogleCloudStorageServiceTests extends ESTestCase {
3736

38-
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/83131")
3937
public void testClientInitializer() throws Exception {
4038
final String clientName = randomAlphaOfLength(randomIntBetween(1, 10)).toLowerCase(Locale.ROOT);
4139
final TimeValue connectTimeValue = TimeValue.timeValueNanos(randomIntBetween(0, 2000000));
@@ -95,7 +93,6 @@ void notifyProxyIsSet(Proxy p) {
9593
((HttpTransportOptions) storage.getOptions().getTransportOptions()).getReadTimeout(),
9694
Matchers.is((int) readTimeValue.millis())
9795
);
98-
assertThat(storage.getOptions().getCredentials(), Matchers.nullValue(Credentials.class));
9996
assertThat(proxy.get().toString(), equalTo("HTTP @ /192.168.52.15:8080"));
10097
}
10198

0 commit comments

Comments
 (0)