HostString throws ArgumentNullException for null host (#1045)

JamesNK · Tratcher · commit f6e20a38e292 · 2018-10-10T08:27:33.000-07:00
diff --git a/src/Microsoft.AspNetCore.Http.Abstractions/HostString.cs b/src/Microsoft.AspNetCore.Http.Abstractions/HostString.cs
@@ -35,7 +35,12 @@ public HostString(string value)
         /// <param name="port">A positive, greater than 0 value representing the port in the host string.</param>
         public HostString(string host, int port)
         {
-            if(port <= 0)
+            if (host == null)
+            {
+                throw new ArgumentNullException(nameof(host));
+            }
+
+            if (port <= 0)
             {
                 throw new ArgumentOutOfRangeException(nameof(port), Resources.Exception_PortMustBeGreaterThanZero);
             }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,12 @@ public HostString(string value)`
`35`	`35`	`/// <param name="port">A positive, greater than 0 value representing the port in the host string.</param>`
`36`	`36`	`public HostString(string host, int port)`
`37`	`37`	`{`
`38`		`- if(port <= 0)`
	`38`	`+ if (host == null)`
	`39`	`+ {`
	`40`	`+ throw new ArgumentNullException(nameof(host));`
	`41`	`+ }`
	`42`	`+`
	`43`	`+ if (port <= 0)`
`39`	`44`	`{`
`40`	`45`	`throw new ArgumentOutOfRangeException(nameof(port), Resources.Exception_PortMustBeGreaterThanZero);`
`41`	`46`	`}`