Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: async-library/react-async
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: next
Choose a base ref
...
head repository: async-library/react-async
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: run-promise-reject
Choose a head ref
  • 4 commits
  • 5 files changed
  • 2 contributors

Commits on May 13, 2019

  1. BUGFIX: Fix handleReject (#47) 

    * Fix handleReject

By simply returning the error it changed the promise chain from rejected to resolved which was causing me issues.

* prettier issue
    @ghengeveld
    Kent C. Dodds authored and ghengeveld committed May 13, 2019
    Configuration menu
    Copy the full SHA
    a4c7a4c View commit details
    Browse the repository at this point in the history

  2. Only re-throw for 'run'. Add same logic also for Async component.

    @ghengeveld
    ghengeveld committed May 13, 2019
    Configuration menu
    Copy the full SHA
    d0e6a73 View commit details
    Browse the repository at this point in the history

  3. Add yarn.lock.

    @ghengeveld
    ghengeveld committed May 13, 2019
    Configuration menu
    Copy the full SHA
    f3fbca5 View commit details
    Browse the repository at this point in the history

  4. Skip some failing tests for now...

    @ghengeveld
    ghengeveld committed May 13, 2019
    Configuration menu
    Copy the full SHA
    88bc929 View commit details
    Browse the repository at this point in the history
Loading